Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the jest-haste-map mapper option #8299

Merged
merged 2 commits into from Apr 10, 2019
Merged

Conversation

@arcanis
Copy link
Contributor

arcanis commented Apr 10, 2019

Summary

I forgot in my previous PR to forward the mapper option from the JestHasteMap options to the crawler option. It went unnoticed because the tests directly instantiate the crawler and because in Metro this logic wasn't necessary because the PnP resolution bypassed the Haste map.

I noticed the problem by removing this bypass, which highlighted that the mapper never got called 馃槥

Test plan

Modified my Jest copy locally, checked that the mapper was called as it should be.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2019

Codecov Report

Merging #8299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8299   +/-   ##
======================================
  Coverage    62.2%   62.2%           
======================================
  Files         266     266           
  Lines       10673   10673           
  Branches     2595    2595           
======================================
  Hits         6639    6639           
  Misses       3445    3445           
  Partials      589     589
Impacted Files Coverage 螖
packages/jest-haste-map/src/index.ts 81.26% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 151c961...525b0da. Read the comment docs.

@scotthovestadt scotthovestadt merged commit 820c2b1 into master Apr 10, 2019
11 checks passed
11 checks passed
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190410.7 succeeded
Details
@SimenB SimenB deleted the fixes-mapper-option branch Apr 10, 2019
aliaksandr-yermalayeu added a commit to aliaksandr-yermalayeu/jest that referenced this pull request Jul 16, 2019
* Fixes the jest-haste-map mapper option

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.