Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify mongodb example by using preset #8318

Merged
merged 6 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@vladgolubev
Copy link
Contributor

commented Apr 12, 2019

Summary

I've just published a Jest preset to simplify usage. Since I was the author of the original tutorial, the code underneath remained the same

Test plan

docs: simplify mongodb example by using preset
I've just published a Jest preset to simplify usage. Since I was the author of the original tutorial, the code underneath remained the same

@vladgolubev vladgolubev changed the title docs: simplify mongodb example by using preset Simplify mongodb example by using preset Apr 12, 2019

vladgolubev added some commits Apr 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 12, 2019

Codecov Report

Merging #8318 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8318   +/-   ##
=======================================
  Coverage   62.17%   62.17%           
=======================================
  Files         266      266           
  Lines       10683    10683           
  Branches     2597     2597           
=======================================
  Hits         6642     6642           
  Misses       3452     3452           
  Partials      589      589

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538cef4...0d1440a. Read the comment docs.

@SimenB
Copy link
Collaborator

left a comment

Thanks! Way cleaner 🙂

Could you update the versioned docs?

image

vladgolubev added some commits Apr 18, 2019

@vladgolubev

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Sure thing, @SimenB!

I've just updated the versioned docs!

@SimenB SimenB merged commit cd415e7 into facebook:master Apr 18, 2019

7 of 11 checks passed

ci/circleci: test-node-6 Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
facebook.jest in progress
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.