Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete obsolete emails tag from header comment in test files #8377

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
6 participants
@pedrottimark
Copy link
Collaborator

commented Apr 24, 2019

Summary

Delete 14 occurrences of * @emails oncall+jsinfra line in header comment:

  • e2e/babel-plugin-jest-hoist/__tests__/integration.test.js
  • e2e/babel-plugin-jest-hoist/__tests__/integrationAutomockOff.test.js
  • e2e/babel-plugin-jest-hoist/__tests__/typescript.test.ts
  • e2e/failures/__tests__/assertionCount.test.js
  • e2e/failures/__tests__/assertionError.test.js
  • e2e/failures/__tests__/asyncFailures.test.js
  • e2e/failures/__tests__/errorAfterTestComplete.test.js
  • e2e/failures/__tests__/snapshot.test.js
  • e2e/failures/__tests__/snapshotWithHint.test.js
  • e2e/failures/__tests__/testMacro.test.js
  • e2e/snapshot-mock-fs/__tests__/snapshot.test.js
  • e2e/snapshot/__tests__/secondSnapshot.test.js
  • e2e/snapshot/__tests__/snapshot.test.js
  • packages/jest-runtime/src/__tests__/Runtime-sourceMaps.test.js

Test plan

Now I remember why I didn’t delete them when I first noticed:

  • 5 snapshots in e2e/__tests__/__snapshots__/failures.test.ts.snap
  • 3 toContain expected strings in e2e/__tests__/failures.test.ts

CI will tell us how effective my local testing of Node versions was (made me feel like Simen lite :)

@pedrottimark pedrottimark requested review from SimenB and scotthovestadt Apr 24, 2019

@jeysal

jeysal approved these changes Apr 24, 2019

@@ -4,7 +4,6 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*

This comment has been minimized.

Copy link
@scotthovestadt

scotthovestadt Apr 24, 2019

Contributor

The blank line under license can probably go too, yeah?

This comment has been minimized.

Copy link
@pedrottimark

pedrottimark Apr 24, 2019

Author Collaborator

A few .ts files that I looked at for example have one:

 * LICENSE file in the root directory of this source tree.
 *
 */

This comment has been minimized.

Copy link
@jeysal

jeysal Apr 24, 2019

Collaborator

Yeah it's totally inconsistent across the code base. I've learned to ignore it ^^

This comment has been minimized.

Copy link
@SimenB

SimenB Apr 26, 2019

Collaborator

lazy removal of @flow pragmas is my guess

This comment has been minimized.

Copy link
@pedrottimark

pedrottimark Apr 26, 2019

Author Collaborator

Yes, that is a tactful way to say that I was consistently lazy, bro ❤️

This comment has been minimized.

Copy link
@SimenB

SimenB Apr 26, 2019

Collaborator

😀

@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #8377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8377   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files         266      266           
  Lines       10729    10729           
  Branches     2609     2609           
=======================================
  Hits         6684     6684           
  Misses       3460     3460           
  Partials      585      585

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3c1a1...2b9cf15. Read the comment docs.

@pedrottimark pedrottimark merged commit 8b6464d into facebook:master Apr 26, 2019

11 checks passed

ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190424.14 succeeded
Details

@pedrottimark pedrottimark deleted the pedrottimark:delete-oncall-jsinfra branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.