Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #7089 and add tests to catch the regression(s) in the future. #8405

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
6 participants
@scotthovestadt
Copy link
Contributor

commented May 1, 2019

Summary

See: #7089 (comment)

Test plan

  • Added tests to catch these regression(s) in the future.

@scotthovestadt scotthovestadt requested a review from SimenB May 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 1, 2019

Codecov Report

Merging #8405 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8405      +/-   ##
==========================================
- Coverage   62.37%   62.33%   -0.04%     
==========================================
  Files         266      266              
  Lines       10739    10730       -9     
  Branches     2614     2612       -2     
==========================================
- Hits         6698     6689       -9     
  Misses       3459     3459              
  Partials      582      582
Impacted Files Coverage Δ
packages/jest-snapshot/src/utils.ts 92.42% <ø> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c0e6b...573a80f. Read the comment docs.

@SimenB

SimenB approved these changes May 1, 2019

@pedrottimark
Copy link
Collaborator

left a comment

Looks good. It confused me a minute because reverted PR had replaced tests instead of adding tests.

@scotthovestadt scotthovestadt merged commit 9081612 into facebook:master May 1, 2019

11 checks passed

ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190501.9 succeeded
Details
@timtrinidad

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Should this also remove #7089 from the changelog?

@SimenB

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2019

yeah probably, but since it'll land with #8408 it should be fine 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.