Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-resolve] cache current directory path #8412

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
6 participants
@Connormiha
Copy link
Contributor

commented May 2, 2019

Summary

Just save path.resolve('.') to const because isCurrentDirectory called very often.

Test plan

@codecov-io

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #8412 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8412      +/-   ##
==========================================
+ Coverage   62.32%   62.32%   +<.01%     
==========================================
  Files         266      266              
  Lines       10733    10734       +1     
  Branches     2614     2614              
==========================================
+ Hits         6689     6690       +1     
  Misses       3461     3461              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-resolve/src/defaultResolver.ts 68.57% <50%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4941d12...8555ae0. Read the comment docs.

@jeysal

jeysal approved these changes May 2, 2019

Copy link
Collaborator

left a comment

Great, thanks!

@scotthovestadt
Copy link
Contributor

left a comment

needs changelog :)

@SimenB SimenB merged commit 46afa44 into facebook:master May 3, 2019

0 of 11 checks passed

ci/circleci: lint-and-typecheck CircleCI is running your tests
Details
ci/circleci: test-browser CircleCI is running your tests
Details
ci/circleci: test-jest-circus CircleCI is running your tests
Details
ci/circleci: test-node-10 CircleCI is running your tests
Details
ci/circleci: test-node-11 CircleCI is running your tests
Details
ci/circleci: test-node-6 CircleCI is running your tests
Details
ci/circleci: test-node-8 CircleCI is running your tests
Details
ci/circleci: test-or-deploy-website CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview processing.
Details
facebook.jest in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.