Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-get-type] Simplify checking for primitive #8416

Merged
merged 2 commits into from May 4, 2019

Conversation

Projects
None yet
5 participants
@Connormiha
Copy link
Contributor

commented May 3, 2019

Summary

I just simplified checking for primitive type and improve performance.

Test plan

There were already tests, but I added some more

@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #8416 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8416      +/-   ##
==========================================
- Coverage   62.32%   62.32%   -0.01%     
==========================================
  Files         266      266              
  Lines       10734    10733       -1     
  Branches     2615     2614       -1     
==========================================
- Hits         6690     6689       -1     
  Misses       3461     3461              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-get-type/src/index.ts 89.65% <100%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bf7c7...1ec9cbc. Read the comment docs.

@scotthovestadt

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Benchmarks on perf?

@Connormiha

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@jeysal

jeysal approved these changes May 3, 2019

Copy link
Collaborator

left a comment

That's actually a quite beautiful way of doing it 👌

@scotthovestadt
Copy link
Contributor

left a comment

Elegant solution.

Change log please.

@scotthovestadt scotthovestadt merged commit 845728f into facebook:master May 4, 2019

11 checks passed

ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190504.1 succeeded
Details

@pedrottimark pedrottimark referenced this pull request May 4, 2019

Open

feat: BigInt Support #8382

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.