Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE: Follow copyright header guidelines and delete For Jest software #8428

Merged
merged 2 commits into from May 6, 2019

Conversation

@pedrottimark
Copy link
Collaborator

pedrottimark commented May 6, 2019

Summary

I noticed View license as text of link on jest project page compared to MIT on react project page

This commit removes differences in the LICENSE file for Jest compared to React

  • My theory is For Jest software line is causing GitHub not to match the license text as MIT
  • For the copyright line, see facebook/react#13593

Test plan

See if GitHub matches the LICENSE file :)

@scotthovestadt

This comment has been minimized.

Copy link
Contributor

scotthovestadt commented May 6, 2019

Looks fine to me.

@cpojer Review please

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #8428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8428   +/-   ##
=======================================
  Coverage   62.32%   62.32%           
=======================================
  Files         266      266           
  Lines       10733    10733           
  Branches     2614     2615    +1     
=======================================
  Hits         6689     6689           
  Misses       3461     3461           
  Partials      583      583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a722791...86bd979. Read the comment docs.

@cpojer
cpojer approved these changes May 6, 2019
Copy link
Contributor

cpojer left a comment

👍

@cpojer cpojer merged commit f2eaf4b into facebook:master May 6, 2019
9 of 11 checks passed
9 of 11 checks passed
deploy/netlify Deploy preview processing.
Details
facebook.jest in progress
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pedrottimark

This comment has been minimized.

Copy link
Collaborator Author

pedrottimark commented May 6, 2019

Now it says MIT, for every eye to see :)

@pedrottimark pedrottimark deleted the pedrottimark:match-license branch May 6, 2019
aliaksandr-yermalayeu added a commit to aliaksandr-yermalayeu/jest that referenced this pull request Jul 16, 2019
…are (facebook#8428)

* LICENSE: Follow copyright header guidelines and delete For Jest software

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.