Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the cli to use a string for --maxWorkers #8565

Merged
merged 6 commits into from Jun 24, 2019

Conversation

@philiiiiiipp
Copy link
Contributor

philiiiiiipp commented Jun 14, 2019

Summary

Fixes #8559 and allows --maxWorkers 20% to be used again.

Test plan

I did add tests and added an example to the cli output, however testing the args in specific is one level higher and would require more thought.

Philipp Beau added 2 commits Jun 14, 2019
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jun 14, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Philipp Beau
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 14, 2019

Codecov Report

Merging #8565 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8565      +/-   ##
==========================================
- Coverage    63.2%   63.18%   -0.03%     
==========================================
  Files         271      271              
  Lines       11284    11296      +12     
  Branches     2749     2754       +5     
==========================================
+ Hits         7132     7137       +5     
- Misses       3538     3544       +6     
- Partials      614      615       +1
Impacted Files Coverage Δ
packages/jest-config/src/Defaults.ts 100% <ø> (ø) ⬆️
packages/jest-config/src/Descriptions.ts 100% <ø> (ø) ⬆️
packages/jest-config/src/ValidConfig.ts 100% <ø> (ø) ⬆️
packages/jest-config/src/normalize.ts 78.2% <100%> (ø) ⬆️
packages/jest-config/src/getMaxWorkers.ts 100% <100%> (ø) ⬆️
packages/jest-validate/src/validate.ts 78.04% <22.22%> (-15.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d3db2...e17660f. Read the comment docs.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Jun 18, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@thymikee thymikee requested a review from jeysal Jun 18, 2019
Copy link
Collaborator

jeysal left a comment

Cool, thanks! Kind of uncomfortable not having an integration test for this but at least yargs is pretty declarative so it might be hard to break it in this place again

packages/jest-cli/src/cli/args.ts Show resolved Hide resolved
jeysal and others added 3 commits Jun 18, 2019
Philipp Beau
@SimenB SimenB merged commit b644d85 into facebook:master Jun 24, 2019
11 checks passed
11 checks passed
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-jest-circus Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190623.8 succeeded
Details
aliaksandr-yermalayeu added a commit to aliaksandr-yermalayeu/jest that referenced this pull request Jul 16, 2019
This was referenced Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.