Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export necessary types from jest-runner #8825

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@M4rk9696
Copy link
Contributor

M4rk9696 commented Aug 14, 2019

Summary

The following type are required to be exported from jest-runner, so that they can be imported when writing a runner in Typescript

Type signature of runTests

async runTests(
  tests: Array<Test>,
  watcher: TestWatcher,
  onStart: OnTestStart,
  onResult: OnTestSuccess,
  onFailure: OnTestFailure,
  options: TestRunnerOptions,
): Promise<void>

Types needed to be exported

OnTestFailure
OnTestStart
OnTestSuccess
TestWatcher 
TestRunnerContext 
TestRunnerOptions

Needed for #8810

/cc @SimenB

Test plan

The existing test cases should cover it, will be adding a test using the types when raising a PR for
#8810

@SimenB
SimenB approved these changes Aug 14, 2019
@SimenB

This comment has been minimized.

Copy link
Collaborator

SimenB commented Aug 14, 2019

Mind updating the changelog?

@M4rk9696

This comment has been minimized.

Copy link
Contributor Author

M4rk9696 commented Aug 15, 2019

Done

@SimenB SimenB merged commit 3ab2fc1 into facebook:master Aug 15, 2019
10 of 11 checks passed
10 of 11 checks passed
ci/circleci: test-jest-circus Your tests failed on CircleCI
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: test-browser Your tests passed on CircleCI!
Details
ci/circleci: test-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-node-11 Your tests passed on CircleCI!
Details
ci/circleci: test-node-6 Your tests passed on CircleCI!
Details
ci/circleci: test-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-or-deploy-website Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
facebook.jest #20190815.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.