Skip to content
Permalink
Browse files

Migrate away from TAsyncSocket::ConnectCallback

Summary:
[Thrift] Migrate away from `TAsyncSocket::ConnectCallback` and replace all uses with `AsyncSocket::ConnectCallback`.

There is no specific need for Thrift to maintain its own parallel hierarchy of the async io types, so unwind that parallel hierarchy in stages.

Reviewed By: iahs

Differential Revision: D19474412

fbshipit-source-id: a9c2e0aaae754fa36d0c6eebf059c38566181488
  • Loading branch information
yfeldblum authored and facebook-github-bot committed Feb 13, 2020
1 parent 7d800e5 commit e3ae9e3291555dff1314aa692e90727d9bb4b768
Showing with 1 addition and 1 deletion.
  1. +1 −1 mcrouter/lib/network/AsyncMcClientImpl.h
@@ -180,7 +180,7 @@ class AsyncMcClientImpl : public folly::DelayedDestruction,
void logErrorWithContext(folly::StringPiece reason);
folly::StringPiece clientStateToStr() const;

// TAsyncSocket::ConnectCallback overrides
// AsyncSocket::ConnectCallback overrides
void connectSuccess() noexcept final;
void connectErr(const folly::AsyncSocketException& ex) noexcept final;

0 comments on commit e3ae9e3

Please sign in to comment.
You can’t perform that action at this time.