Skip to content
Permalink
Branch: master
Commits on Nov 20, 2019
  1. Add UNLIKELY to getThriftClient

    stuclar authored and facebook-github-bot committed Nov 20, 2019
    Summary: As above
    
    Reviewed By: alikhtarov
    
    Differential Revision: D18621267
    
    fbshipit-source-id: 17cd9927228b0885de65ad19102f4d5ccfadc570
  2. folly depends on fmt in oss makefile

    disylh authored and facebook-github-bot committed Nov 20, 2019
    Reviewed By: stuclar
    
    Differential Revision: D18623322
    
    fbshipit-source-id: bbb50e7318b9c646e7bafed7522be1df87654816
  3. Determine ModifyExptimeRoute action during reconfig

    Pavlo Kushnir authored and facebook-github-bot committed Nov 20, 2019
    Summary: Doesn't improve memory or CPU usage a lot but just nice to have.
    
    Reviewed By: stuclar
    
    Differential Revision: D18297878
    
    fbshipit-source-id: 8014e19f53a4dff20aae701c5338ea3a69261994
  4. Add LIKELY to Thrift Transport hot path

    stuclar authored and facebook-github-bot committed Nov 20, 2019
    Summary: As above
    
    Reviewed By: jmswen
    
    Differential Revision: D18611645
    
    fbshipit-source-id: d9d5662e1cf8cdffd7dc459e4f029a98a0fb842e
  5. Reduce memory usage in ProxyDestinationMap

    Pavlo Kushnir authored and facebook-github-bot committed Nov 20, 2019
    Summary:
    With heterogeneous find available in `folly::F14` containers, we can store pointer to ProxyDestination and use lookup with a custom key. There is no need to store string key anymore.
    Furthermore, there is no need to store weak pointers. Since for the entire lifetime of ProxyDestination we store it in a map and in destructor we remove it from the map, storing raw pointer should be fine. This also removes races with ProxyDestination destruction on stats thread.
    
    Reviewed By: stuclar
    
    Differential Revision: D18297873
    
    fbshipit-source-id: 026e4f202594f8f3007605e2d8be0a4e46b5ea8b
  6. Create route handle based on routing groups

    Sidharth Verma authored and facebook-github-bot committed Nov 20, 2019
    Summary: Similar to OperationSelectorRoute, except that routing is done by routing group (get, set, delete, arithmetic).
    
    Reviewed By: stuclar
    
    Differential Revision: D17691007
    
    fbshipit-source-id: bbc9623aff9b16b14153a6c2965cbcd7289bd80b
  7. Fix bug in AsyncTlsToPlaintextSocket

    jmswen authored and facebook-github-bot committed Nov 20, 2019
    Summary:
    This diff fixes an obvious bug where, currently, an always-null `readCallback_` will be dereferenced in case `close()`/`closeNow()` is somehow called before `connectSuccess()`/`connectErr()` fires. This is mostly out of caution; we haven't observed this behavior anywhere.
    
    This diff also 1) adds an `UNLIKELY` hint to the somewhat hot `writeChain` function and 2) makes `getReadCallback()` more usable, working even if the socket is not in the connected state. (This function is mostly for testing AFAIK so this is a minor but straightforward improvement.)
    
    Reviewed By: stuclar
    
    Differential Revision: D18598726
    
    fbshipit-source-id: bfce1967db85b9428afd5c793d81cdfba8126c40
Commits on Nov 16, 2019
  1. Move config backups to a separate thread

    andriigrynenko authored and facebook-github-bot committed Nov 16, 2019
    Reviewed By: stuclar
    
    Differential Revision: D18545166
    
    fbshipit-source-id: b6b132142a6f553432a035706bf9627911a389ba
Commits on Nov 15, 2019
  1. Make retries configurable in L1L2SizeSplitRoute for gets and lease-get

    Yufeng Wu authored and facebook-github-bot committed Nov 15, 2019
    Summary: Make retries configurable
    
    Differential Revision: D18491489
    
    fbshipit-source-id: 9eacf6a8112249b7f869fe0697da50349bba009f
Commits on Nov 13, 2019
  1. enable -Wunused-exception-parameter

    chadaustin authored and facebook-github-bot committed Nov 13, 2019
    Reviewed By: yfeldblum
    
    Differential Revision: D18414340
    
    fbshipit-source-id: 7ea92b119c7b12ced4f92e365c15bd59fbce0461
Commits on Nov 12, 2019
  1. Reduce memory usage in ProxyDestination

    Pavlo Kushnir authored and facebook-github-bot committed Nov 12, 2019
    Summary:
    There is no need to store `routerNameInfo` for every `ProxyDestination`.
    `qosPath` and `qosClass` are `unsigned int` in `ConnectionOptions` (also we check values are in range 0..4 and 0..3 respectively on reconfig).
    
    Reviewed By: stuclar
    
    Differential Revision: D18297877
    
    fbshipit-source-id: 12ece1f6fefb11c413fcdcb721a8131948cad77d
Commits on Nov 10, 2019
  1. Move tao custom mcrouter rate stats to rate stats section

    vrishal authored and facebook-github-bot committed Nov 10, 2019
    Summary: My attempt to turn tao custom mcrouter stats to rate stats with D18310242 miserably failed. Apparently just using STUIR doesn't give you rate stats. You also have to move it into rate_stats section :(
    
    Differential Revision: D18408513
    
    fbshipit-source-id: ead1b7a5dd77ee3c88d731fef5342cd6445d5c81
Commits on Nov 7, 2019
  1. Move out failover reply to avoid copy

    Alexander Zhavnerchik authored and facebook-github-bot committed Nov 7, 2019
    Summary: I cought this when using move only type in Carbon struct. In general this looks like a good fix to avoid copying reply.
    
    Reviewed By: stuclar
    
    Differential Revision: D18366993
    
    fbshipit-source-id: be63c45608ec3ffbc1671715fc09908dff603ea3
  2. split travis build to two jobs and use cache storing dependency

    disylh authored and facebook-github-bot committed Nov 7, 2019
    Summary:
    mcrouter oos travis build could still timeout because total build time is longer than 50mins. This diff split travis build into two staged jobs: build_deps_and_cache and mcrouter.
    Job build_deps_and_cache builds fb dependencies and stores in travis cache, took ~32mins
    Job mcrouter fetches the dependency file from cache and continue mcrouter build, took ~34mins
    
    Although each travis job has 50mins limit, there is no limit on total build time. Using cache so that jobs could share progress  between each other. This way also make sure we have enough room for future build time increase.
    
    Reviewed By: edenzik
    
    Differential Revision: D18372976
    
    fbshipit-source-id: a7bf45432e5603d3c2a93528772e54770b0efb9f
  3. Update Mcpiper to print Thrift Structures using JSONSerializer

    Soham Shah authored and facebook-github-bot committed Nov 7, 2019
    Summary: Use JSONSerializer to print thrift objects.
    
    Reviewed By: stuclar
    
    Differential Revision: D17744765
    
    fbshipit-source-id: 6ed74e173642e412a16bd8be1eda511fd13d48c8
  4. Templetize CarbonProtocolWriter to work with different types of storage

    Cornel Rat authored and facebook-github-bot committed Nov 6, 2019
    Summary: - Enable defining different storage implementations for carbon serialization
    
    Differential Revision: D18335108
    
    fbshipit-source-id: 2e2d3650355609a5b50be02fb34f4dbba78d9be4
  5. Build script for ubuntu18.04 & parallel build to shorten total build …

    disylh authored and facebook-github-bot committed Nov 6, 2019
    …time to avoid 50 mins travis-ci job timeout
    
    Reviewed By: edenzik
    
    Differential Revision: D18173394
    
    fbshipit-source-id: 4b47515eebaf065923ffe643dc6318cafd2bab6d
  6. Merge pull request #328 from yns88/fixup-T44452982-master

    yns88 committed Nov 7, 2019
    Re-sync with internal repository
  7. Re-sync with internal repository

    yns88 committed Nov 7, 2019
Commits on Nov 6, 2019
  1. Reduce memory used by configs

    Pavlo Kushnir authored and facebook-github-bot committed Nov 6, 2019
    Summary: Avoid redundant memory in vectors.
    
    Reviewed By: ftimyo
    
    Differential Revision: D18297867
    
    fbshipit-source-id: a1eb6ff28d0ef8470ba78903e7498c2828ab598c
  2. Client authorization

    stuclar authored and facebook-github-bot committed Nov 6, 2019
    Summary:
    McRouter client now has the ability to authorize the TLS service identity of the servers that it connects to with the expected identity configured in ssl_service_identity.
    
    The following flavor options have been added:
    
        ssl_service_identity_authorization_log: "The configured service identity of the client is compared against the service identity of the server in the peer certificate. Log if they match."
    
        ssl_service_identity_authorization_enforce: "The configured service identity of the client is compared against the service identity of the server in the peer certificate. Fail to connect if they do not match."
    
    The stat "num_authorization_failures" has also been added which tracks the number of authentication failures.
    
    Reviewed By: jmswen
    
    Differential Revision: D17993322
    
    fbshipit-source-id: 69fac1f7f62d1d87a3a9e5f5f4c1c6826863cf52
  3. Simplify the unittest for DeterminsticFailover

    ftimyo authored and facebook-github-bot committed Nov 6, 2019
    Reviewed By: djvaporize
    
    Differential Revision: D18342528
    
    fbshipit-source-id: 208b14d3248af145a42c4346903622f416834310
Commits on Nov 5, 2019
  1. Change tao specific mcrouter stats to rate stats

    vrishal authored and facebook-github-bot committed Nov 5, 2019
    Summary: The deadline, master region failover stats were count stats instead of rate stats.
    
    Differential Revision: D18310242
    
    fbshipit-source-id: fb70fefede7dfc06eb752be8f8d9287e45b6d49a
Commits on Nov 4, 2019
  1. Attempt to make CarbonProtocolReader::skip tail recursive

    theopolis authored and facebook-github-bot committed Nov 4, 2019
    Reviewed By: edenzik
    
    Differential Revision: D17967570
    
    fbshipit-source-id: fdc32e190a521349c7c8f4d6081902fa18eb0284
Commits on Nov 1, 2019
  1. Fix OSS build

    jmswen authored and facebook-github-bot committed Nov 1, 2019
    Reviewed By: stuclar
    
    Differential Revision: D18278096
    
    fbshipit-source-id: 4b5e97e6b8e4da061950aabfdb33e92225a42cda
Commits on Oct 30, 2019
  1. Switch ThriftTransport to use non-throwing Thrift client

    jmswen authored and facebook-github-bot committed Oct 30, 2019
    Summary: This diff changes the behavior of generated `ThriftTransport` clients to not throw on application/transport exceptions. Namely, exceptions will no longer be thrown on timeouts.
    
    Reviewed By: stuclar
    
    Differential Revision: D17578304
    
    fbshipit-source-id: 29fe1207a3bccf2ad76893fcf67bfeaa01710d5d
Commits on Oct 29, 2019
  1. Bump makefile boost version to 1.65

    yfeldblum authored and facebook-github-bot committed Oct 29, 2019
    Summary:
    [Mcrouter] Bump makefile boost version from 1.51 to 1.65.
    
    This also bumps the Ubuntu release shipping the minimum boost version from 16.04 LTS (xenial) to 18.04 LTS (bionic).
    
    Reviewed By: stuclar
    
    Differential Revision: D18189491
    
    fbshipit-source-id: f7d33f0d366403f3dba88059071a21196f903c22
  2. Allow Mcrouter to use passed in split size for shard split routing

    Yu Sui authored and facebook-github-bot committed Oct 29, 2019
    Summary: As of now Mcrouter uses shard split size in routing config when doing shard split routing. When dynamic replicas is enabled for TAO server, Mcrouter needs to use the maximum split size instead. This diff adds splitSize as a configurable option to RouteHandleTraverser, which gives callers the ability to control Mcrouter behavior by explicitly passing in splitSize.
    
    Reviewed By: stuclar
    
    Differential Revision: D17923424
    
    fbshipit-source-id: 7a09a37b4b59bfe1949344c14cf42e9ab84cca5d
Commits on Oct 28, 2019
  1. Add getLocalAddress API to McServerSession

    kkondaka authored and facebook-github-bot committed Oct 28, 2019
    Summary: Add getLocalAddress API to McServerSession
    
    Reviewed By: stuclar
    
    Differential Revision: D18145522
    
    fbshipit-source-id: 53bb993bb0d2e54954d2c926a81312b16887e858
Commits on Oct 15, 2019
  1. make enable/disable shadow shards independent from shards for EagerSh…

    ftimyo authored and facebook-github-bot committed Oct 15, 2019
    …ardSelectionShadowRoute
    
    Summary:
    There is a corner case where EagerShardSelectionShadowRoute does not route shadow shard requests when shards is empty.
    
    Before this fix, we optimized SelectionRoute to ErrorRoute when shards is empty.
    After this fix, we optimized SelectionRoute to ErrorRoute only when both shards and shardow_shards are empty.
    
    (Note: this ignores all push blocking failures!)
    
    Reviewed By: stuclar
    
    Differential Revision: D17741973
    
    fbshipit-source-id: 5c1e49e113acdcc8ea25d248ca6ba6162cacdd32
Commits on Oct 14, 2019
  1. Tidy up license headers [3/3]

    zertosh authored and facebook-github-bot committed Oct 14, 2019
    Reviewed By: mzlee
    
    Differential Revision: D17901955
    
    fbshipit-source-id: b19baccf21092201036f1229882563534ddd556c
  2. Tidy up license headers [2/3]

    zertosh authored and facebook-github-bot committed Oct 14, 2019
    Differential Revision: D17901958
    
    fbshipit-source-id: 3448e72f570d703afa5c0ab91724c1e61015f85e
  3. Tidy up license headers [1/3]

    zertosh authored and facebook-github-bot committed Oct 14, 2019
    Reviewed By: mzlee
    
    Differential Revision: D17901957
    
    fbshipit-source-id: 17c8a90e043a9cd522ca031668bc495731ce888e
Commits on Oct 10, 2019
  1. split McrouterManager to its own h/cpp files

    ghostonhuang authored and facebook-github-bot committed Oct 10, 2019
    Summary: as title. so that it can be used directly
    
    Reviewed By: glamtechie
    
    Differential Revision: D17777557
    
    fbshipit-source-id: 83df99680cc904e5f2eccdf79016601cf67da055
Commits on Oct 9, 2019
  1. support pool object in SaltedFailoverRoute config

    Lu Pan authored and facebook-github-bot committed Oct 9, 2019
    Summary: Support passing an object to "pool" in the SaltedFailoverRoute config, besides just string e.g. "Pool|A".
    
    Reviewed By: stuclar
    
    Differential Revision: D17805971
    
    fbshipit-source-id: 0167fb022203e13adf1272685a1acb959133b9bd
Older
You can’t perform that action at this time.