Skip to content
Permalink
Branch: master
Commits on Feb 13, 2020
  1. Migrate away from TAsyncSocket::ConnectCallback

    yfeldblum authored and facebook-github-bot committed Feb 13, 2020
    Summary:
    [Thrift] Migrate away from `TAsyncSocket::ConnectCallback` and replace all uses with `AsyncSocket::ConnectCallback`.
    
    There is no specific need for Thrift to maintain its own parallel hierarchy of the async io types, so unwind that parallel hierarchy in stages.
    
    Reviewed By: iahs
    
    Differential Revision: D19474412
    
    fbshipit-source-id: a9c2e0aaae754fa36d0c6eebf059c38566181488
Commits on Jan 20, 2020
  1. Remove TAsyncTransport as a base class

    yfeldblum authored and facebook-github-bot committed Jan 20, 2020
    Summary:
    [Thrift] Remove `TAsyncTransport` as a base class, replacing all uses with the underlying `folly::AsyncTransportWrapper`.
    
    The only thing that `TAsyncTransport` provides is custom error callbacks which translate exceptions from `AsyncSocketException` to `TTransportException`. Just take this translation and move it to the few places which actually do anything with the exceptions.
    
    Reviewed By: bithree
    
    Differential Revision: D19287953
    
    fbshipit-source-id: a7fb1f73b700a7f21f9fed8e9bc70ecad9a53cd4
Commits on Oct 29, 2019
  1. Bump makefile boost version to 1.65

    yfeldblum authored and facebook-github-bot committed Oct 29, 2019
    Summary:
    [Mcrouter] Bump makefile boost version from 1.51 to 1.65.
    
    This also bumps the Ubuntu release shipping the minimum boost version from 16.04 LTS (xenial) to 18.04 LTS (bionic).
    
    Reviewed By: stuclar
    
    Differential Revision: D18189491
    
    fbshipit-source-id: f7d33f0d366403f3dba88059071a21196f903c22
Commits on Sep 19, 2019
  1. Support -Werror=unused-function

    yfeldblum authored and facebook-github-bot committed Sep 19, 2019
    Summary: Support `-Werror=unused-function`.
    
    Reviewed By: Orvid, guangyfb
    
    Differential Revision: D17252831
    
    fbshipit-source-id: ccf3829ebaa6992341ff5b1ab84c173922eeae03
Commits on Sep 7, 2019
  1. Bake templates into the compiler binary

    yfeldblum authored and facebook-github-bot committed Sep 7, 2019
    Summary: [Thrift] Bake templates into the compiler binary rather than having to package the templates with the compiler.
    
    Reviewed By: stevegury, vitaut
    
    Differential Revision: D16356056
    
    fbshipit-source-id: b971dce7aada8dc2a26587fbf818e661acd0c555
  2. Support -Werror=unused-variable across various projects

    yfeldblum authored and facebook-github-bot committed Sep 7, 2019
    Summary: Support `-Werror=unused-variable` across various projects.
    
    Reviewed By: Orvid
    
    Differential Revision: D17180350
    
    fbshipit-source-id: 259c0911ec4fc59b1aef499d7610d1489615fc8b
Commits on Mar 7, 2019
  1. Add assorted missing includes

    yfeldblum authored and facebook-github-bot committed Mar 7, 2019
    Summary: [Mcrouter] Add assorted missing `#include`s.
    
    Reviewed By: andreazevedo
    
    Differential Revision: D14293718
    
    fbshipit-source-id: d50caced9454490b3906b1ca4667124c5cc972f5
Commits on Mar 1, 2019
  1. Remove include of glog from Range.h

    yfeldblum authored and facebook-github-bot committed Mar 1, 2019
    Summary: [Folly] Remove include of `glog` from `Range.h`.
    
    Reviewed By: lbrandy, Orvid
    
    Differential Revision: D14114164
    
    fbshipit-source-id: e227609e9214ab39ff272e44519d34f3047fe025
Commits on Feb 28, 2019
  1. Stop checking EventBase::runInEventBaseThread result

    yfeldblum authored and facebook-github-bot committed Feb 28, 2019
    Summary:
    [Folly] Stop checking `EventBase::runInEventBaseThread` result, as the function will soon be changed not to return any result.
    
    It returned `false` when failing to enqueue a task. But it cannot really fail anyway besides allocation failure, unless in the `EventBase` destructor and while draining and the `AlwaysEnqueue` variant is called.
    
    Reviewed By: andriigrynenko
    
    Differential Revision: D14254969
    
    fbshipit-source-id: a6a9199cbafa18b61488a240e4318ce946953f51
Commits on Apr 12, 2018
  1. Rename IOBufEqual to IOBufEqualTo

    yfeldblum authored and facebook-github-bot committed Apr 12, 2018
    Summary: [Folly] Rename `IOBufEqual` to `IOBufEqualTo` to correspond with the standard naming of `std::equal_to`.
    
    Reviewed By: Orvid
    
    Differential Revision: D7596716
    
    fbshipit-source-id: 2e87aa4b62a002520bdd53b5b7eaba7d9bd822da
Commits on Jan 30, 2018
  1. Rewrite copyright-year lines

    yfeldblum authored and facebook-github-bot committed Jan 30, 2018
    Summary: [Mcrouter] Rewrite copyright-year lines based on file histories.
    
    Reviewed By: andreazevedo
    
    Differential Revision: D6841539
    
    fbshipit-source-id: 0c757bc119252f5c9ff7af71605e8aefd518b622
Commits on Dec 20, 2017
  1. Kill FOLLY_ALIGNED etc

    yfeldblum authored and facebook-github-bot committed Dec 20, 2017
    Summary:
    [Folly] Kill `FOLLY_ALIGNED` etc.
    
    `alignas` is standardized as of C++11. Let us just use that.
    
    Replace:
    * `FOLLY_ALIGNED` with `alignas`
    * `FOLLY_ALIGNED_MAX` with `alignas(folly::max_align_v)`
    * `FOLLY_ALIGN_TO_AVOID_FALSE_SHARING` with `alignas(folly::hardware_destructive_interference_size)`
    
    Because where `alignas` may be placed is more restrictive than where attributes may be placed, we also need to move these directives in some cases on top of doing the replacement.
    
    Reviewed By: Orvid
    
    Differential Revision: D6555167
    
    fbshipit-source-id: 4b05b570bace3f8c0fe810b6dd58781dd45757f4
Commits on Dec 8, 2017
  1. Move folly/Bits.h to folly/lang/

    yfeldblum authored and facebook-github-bot committed Dec 8, 2017
    Summary: [Folly] Move `folly/Bits.h` to `folly/lang/`.
    
    Reviewed By: phoad, Orvid
    
    Differential Revision: D6495547
    
    fbshipit-source-id: a93159321df8277f8a4b4f10a5e4e0fc58cb6022
Commits on Dec 6, 2017
  1. Move folly/Baton.h to folly/synchronization/

    yfeldblum authored and facebook-github-bot committed Dec 6, 2017
    Summary: [Folly] Move `folly/Baton.h` to `folly/synchronization/`.
    
    Reviewed By: phoad, Orvid
    
    Differential Revision: D6490282
    
    fbshipit-source-id: 66e2d25ffe3275d576b97b81c1987709000f6649
Commits on Oct 29, 2017
  1. CodeMod: Replace includes of folly/Hash.h with folly/hash/Hash.h

    yfeldblum authored and facebook-github-bot committed Oct 29, 2017
    Summary: CodeMod: Replace includes of `folly/Hash.h` with `folly/hash/Hash.h`.
    
    Reviewed By: luciang
    
    Differential Revision: D6156195
    
    fbshipit-source-id: 0941b3c9cf1d17d7cc62595111e506c06ee51236
Commits on Oct 22, 2017
  1. CodeMod: Replace wangle/concurrency with folly/executors

    yfeldblum authored and facebook-github-bot committed Oct 22, 2017
    Summary:
    CodeMod: Replace `wangle/concurrency` with `folly/executors`.
    
    The headers in `wangle/concurrency/` are now but shims to equivalent headers in `folly/executors/`.
    
    Reviewed By: jsedgwick
    
    Differential Revision: D6120852
    
    fbshipit-source-id: 358ceabea7ad79f84b803ed8e3aecb2a57fdd077
Commits on Oct 20, 2017
  1. CodeMod: Replace all uses of wangle::CPUThreadPoolExecutor with folly…

    yfeldblum authored and facebook-github-bot committed Oct 20, 2017
    …::CPUThreadPoolExecutor
    
    Summary:
    CodeMod: Replace all uses of `wangle::CPUThreadPoolExecutor` with `folly::CPUThreadPoolExecutor`.
    
    The former is merely an alias to the latter.
    
    Reviewed By: Orvid
    
    Differential Revision: D6106232
    
    fbshipit-source-id: b91e9246339f987e6915dd415a7179631877ed06
Commits on Oct 19, 2017
  1. Revert D6050464: [Folly] Move folly/Hash.h to folly/hash/

    yfeldblum authored and facebook-github-bot committed Oct 19, 2017
    Summary:
    This reverts commit 64eb65aac8e3e7cd0126e65ca3998bfe167e2d73
    
    bypass-lint
    
    Differential Revision: D6050464
    
    fbshipit-source-id: 1ed63f30837dc11ae57b316f1f7cb233a210894a
  2. Move folly/Hash.h to folly/hash/

    yfeldblum authored and facebook-github-bot committed Oct 19, 2017
    Summary: [Folly] Move `folly/Hash.h` to `folly/hash/`.
    
    Reviewed By: jsedgwick
    
    Differential Revision: D6050464
    
    fbshipit-source-id: 64eb65aac8e3e7cd0126e65ca3998bfe167e2d73
Commits on Oct 16, 2017
  1. CodeMod: Replace uses of wangle::NamedThreadFactory

    yfeldblum authored and facebook-github-bot committed Oct 16, 2017
    Summary: CodeMod: Replace uses of `wangle::NamedThreadFactory` with `folly::NamedThreadFactory`, to which the former is merely an alias.
    
    Reviewed By: Orvid
    
    Differential Revision: D6062557
    
    fbshipit-source-id: a5bc030eee24d40d14efc7095aec4fddf7efcb0b
Commits on Jul 31, 2017
  1. Treat gtest headers as system headers in oss build

    yfeldblum authored and facebook-github-bot committed Jul 31, 2017
    Summary: [Mcrouter] Treat `gtest` headers as system headers in oss build. Using `-isystem` rather than `-I`. To avoid any errors or warnings originating in gtest headers from failing otherwise-clean mcrouter oss builds.
    
    Reviewed By: Orvid
    
    Differential Revision: D5526060
    
    fbshipit-source-id: f66f7c00b220abcb557a6373c4d780788748a7e3
Commits on Jul 24, 2017
  1. Move the SpookyHash libraries into folly/hash

    yfeldblum authored and facebook-github-bot committed Jul 24, 2017
    Summary:
    [Folly] Move the SpookyHash libraries into `folly/hash`.
    
    And propagate the changes to `#include` lines, etc.
    
    Reviewed By: Orvid
    
    Differential Revision: D5477735
    
    fbshipit-source-id: 94fe95ece05b52bde1466ab5f9fb8b53a4c59bed
Commits on Jul 22, 2017
  1. Move the SpookyHash libraries into folly/hash

    yfeldblum authored and facebook-github-bot committed Jul 22, 2017
    Summary:
    [Folly] Move the SpookyHash libraries into `folly/hash`.
    
    And propagate the changes to `#include` lines, etc.
    
    Reviewed By: ot, ericniebler, Orvid
    
    Differential Revision: D5455584
    
    fbshipit-source-id: 616b04579eb6c822023b04840b075f3ac9fbb720
Commits on Jul 17, 2017
  1. CodeMod: Prefer ADD_FAILURE() over EXPECT_TRUE(false), et cetera

    yfeldblum authored and facebook-github-bot committed Jul 17, 2017
    Summary:
    CodeMod: Prefer `ADD_FAILURE()` over `EXPECT_TRUE(false)`, et cetera.
    
    The tautologically-conditioned and tautologically-contradicted boolean expectations/assertions have better alternatives: unconditional passes and failures.
    
    Reviewed By: Orvid
    
    Differential Revision:
    D5432398
    
    Tags: codemod, codemod-opensource
    
    fbshipit-source-id: d16b447e8696a6feaa94b41199f5052226ef6914
Commits on May 28, 2017
  1. Fix violations of sign-compare

    yfeldblum authored and facebook-github-bot committed May 28, 2017
    Summary: [Mcrouter] Fix violations of `sign-compare`.
    
    Reviewed By: andrewjcg
    
    Differential Revision: D5144519
    
    fbshipit-source-id: fe0f13fe0f965f98398d70fd4464cd3631f687ef
Commits on May 21, 2017
  1. Fix violations of unused-parameter

    yfeldblum authored and facebook-github-bot committed May 21, 2017
    Summary: [Mcrouter] Fix violations of `unused-parameter`.
    
    Reviewed By: meyering
    
    Differential Revision: D5059101
    
    fbshipit-source-id: 515bfbc0452888a25639ba21c0a14c033dac6a44
Commits on May 17, 2017
  1. Fix violations of unused-parameter in carbon-generated code

    yfeldblum authored and facebook-github-bot committed May 17, 2017
    Summary: [Mcrouter] Fix violations of `unused-parameter` in carbon-generated code.
    
    Reviewed By: jmswen
    
    Differential Revision: D5077288
    
    fbshipit-source-id: cef556594a8168793ef69a5cd4fffd67999dabc3
  2. Fix some extra-semi violations

    yfeldblum authored and facebook-github-bot committed May 17, 2017
    Summary: Fix some `extra-semi` violations.
    
    Reviewed By: andreazevedo
    
    Differential Revision: D5057962
    
    fbshipit-source-id: ff347f635bf89cc33b85140b52941996e2f7cc95
Commits on May 16, 2017
  1. Fix violations of mismatched-tags

    yfeldblum authored and facebook-github-bot committed May 16, 2017
    Summary: [Mcrouter] Fix violations of `mismatched-tags`.
    
    Reviewed By: spalamarchuk
    
    Differential Revision: D5057770
    
    fbshipit-source-id: a4ffa375d986ee45a0b9b670ae5597152a93c1c2
  2. Fix violations of unreachable-code-break

    yfeldblum authored and facebook-github-bot committed May 16, 2017
    Summary: [Mcrouter] Fix violations of `unreachable-code-break`.
    
    Reviewed By: spalamarchuk
    
    Differential Revision: D5055895
    
    fbshipit-source-id: d0c0b5f6b5ef5c33cb82e22c86f581f7234cee2b
Commits on May 15, 2017
  1. Fix violations of unreachable-code-return

    yfeldblum authored and facebook-github-bot committed May 15, 2017
    Summary: [Mcrouter] Fix violations of `unreachable-code-return`.
    
    Reviewed By: jmswen
    
    Differential Revision: D5055814
    
    fbshipit-source-id: ce27b6636939001fc5b889f991d92d811b82d4e5
  2. Some [[noreturn]] attributes

    yfeldblum authored and facebook-github-bot committed May 15, 2017
    Summary: [Mcrouter] Some `[[noreturn]]` attributes.
    
    Reviewed By: spalamarchuk
    
    Differential Revision: D5055131
    
    fbshipit-source-id: c5a14a56aafe4fc8d694f625c38fe5faaa96573c
Commits on May 1, 2017
  1. Dead Code: mcrouter/lib/McRequestList.h

    yfeldblum authored and facebook-github-bot committed May 1, 2017
    Summary: [Mcrouter] Dead Code: `mcrouter/lib/McRequestList.h`.
    
    Reviewed By: jmswen
    
    Differential Revision: D4977489
    
    fbshipit-source-id: 5009375f392aafc29dbe889977071afcaf75681e
Commits on Mar 13, 2017
  1. No longer use namespace google for gflags

    yfeldblum authored and facebook-github-bot committed Mar 13, 2017
    Summary:
    [Mcrouter] No longer use `namespace google` for `gflags`.
    
    The new thing to use is `namespace gflags`.
    
    Reviewed By: jmswen
    
    Differential Revision: D4663706
    
    fbshipit-source-id: d352931a5b1ac43e0871e0e0f25d5ea100b43943
Commits on Dec 17, 2016
  1. Split EventBaseThread from ScopedEventBaseThread

    yfeldblum authored and facebook-github-bot committed Dec 17, 2016
    Summary:
    [Folly] Split `EventBaseThread` from `ScopedEventBaseThread`.
    
    Now `ScopedEventBaseThread` is really scoped and immovable, while `EventBaseThread` is movable and can be started and stopped.
    
    Users which will never move, and will never start or stop, the `ScopedEventBaseThread` can continue using it. Users which need to move, or which need to start and stop, the object will use `EventBaseThread` instead.
    
    Reviewed By: andriigrynenko
    
    Differential Revision: D4338447
    
    fbshipit-source-id: 57c186630bc199a7a7b7223b1fcb077ce3d86743
Older
You can’t perform that action at this time.