Navigation Menu

Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

Handle case where no reviewers found better #15

Closed
mwarkentin opened this issue Nov 20, 2015 · 3 comments
Closed

Handle case where no reviewers found better #15

mwarkentin opened this issue Nov 20, 2015 · 3 comments

Comments

@mwarkentin
Copy link
Contributor

Just got the following comment on a PR on one of my repos:

By analyzing the blame information on this pull request, we identified @none to be a potential reviewer.

Two options:

  • Improve messaging: We were unable to identify any potential reviewers. Sorry!
  • Don't make a comment at all if no reviewers were found
@vjeux
Copy link
Contributor

vjeux commented Nov 20, 2015

Option #2 is currently implemented. However there's a bug where for some reason @none is being filled there somehow. A fix for this would be to just remove 'none' from the list at the end.

@mwarkentin
Copy link
Contributor Author

Looks like this is where it would need to be changed: https://github.com/facebook/mention-bot/blob/d6b84f924acf254ac885e4bae4fac2059ce03a01/mention-bot.js#L261-L281

@vjeux vjeux mentioned this issue Nov 21, 2015
Merged
@vjeux
Copy link
Contributor

vjeux commented Nov 21, 2015

Fixed: 50638bd

@vjeux vjeux closed this as completed Nov 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwarkentin @vjeux