From e8bb8fb4035699c83fce4b35aabcaec208513f3c Mon Sep 17 00:00:00 2001
From: Rob Hogan <robhogan@fb.com>
Date: Mon, 23 May 2022 06:58:00 -0700
Subject: [PATCH] Add missing .npmignore files

Summary:
I noticed some of our packages publish `src.real` to NPM, which is an intermediate build artefact that shouldn't published. It turns out this is because a few of them are missing the standard `.npmignore`, and so also publishing test code and lock files.

This adds the missing `.npmignore` files, and adds a check to our `subpackages-test.js` for existence and minimal content.

Reviewed By: motiz88

Differential Revision: D36592818

fbshipit-source-id: adac01c5c9d632e3388290a46c3cbc3308b4e239
---
 packages/metro-cache-key/.npmignore        |  5 +++++
 packages/metro-symbolicate/.npmignore      |  5 +++++
 packages/metro-transform-worker/.npmignore |  5 +++++
 scripts/__tests__/subpackages-test.js      | 17 +++++++++++++++++
 4 files changed, 32 insertions(+)
 create mode 100644 packages/metro-cache-key/.npmignore
 create mode 100644 packages/metro-symbolicate/.npmignore
 create mode 100644 packages/metro-transform-worker/.npmignore

diff --git a/packages/metro-cache-key/.npmignore b/packages/metro-cache-key/.npmignore
new file mode 100644
index 0000000000..a0d4570202
--- /dev/null
+++ b/packages/metro-cache-key/.npmignore
@@ -0,0 +1,5 @@
+**/__mocks__/**
+**/__tests__/**
+build
+src.real
+yarn.lock
diff --git a/packages/metro-symbolicate/.npmignore b/packages/metro-symbolicate/.npmignore
new file mode 100644
index 0000000000..a0d4570202
--- /dev/null
+++ b/packages/metro-symbolicate/.npmignore
@@ -0,0 +1,5 @@
+**/__mocks__/**
+**/__tests__/**
+build
+src.real
+yarn.lock
diff --git a/packages/metro-transform-worker/.npmignore b/packages/metro-transform-worker/.npmignore
new file mode 100644
index 0000000000..a0d4570202
--- /dev/null
+++ b/packages/metro-transform-worker/.npmignore
@@ -0,0 +1,5 @@
+**/__mocks__/**
+**/__tests__/**
+build
+src.real
+yarn.lock
diff --git a/scripts/__tests__/subpackages-test.js b/scripts/__tests__/subpackages-test.js
index 8c165fc15a..7c1c9dc89c 100644
--- a/scripts/__tests__/subpackages-test.js
+++ b/scripts/__tests__/subpackages-test.js
@@ -81,3 +81,20 @@ it('forces all packages to have a src/ folder', () => {
     );
   });
 });
+
+it('forces all packages to have an .npmignore with expected entries', () => {
+  checkAssertionInPackages(getPackages(), packagePath => {
+    const npmIgnorePath = path.join(packagePath, '.npmignore');
+    expect(fs.existsSync(npmIgnorePath)).toBe(true);
+    const lines = fs.readFileSync(npmIgnorePath, 'utf-8').split('\n');
+    expect(lines).toEqual(
+      expect.arrayContaining([
+        '**/__mocks__/**',
+        '**/__tests__/**',
+        'build',
+        'src.real',
+        'yarn.lock',
+      ]),
+    );
+  });
+});