Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use utf8 charset for bundle response #695

Closed
wants to merge 2 commits into from

Conversation

zhiqingchen
Copy link
Contributor

@zhiqingchen zhiqingchen commented Aug 4, 2021

Summary

The content-type value of bundle server's response header should be 'application/javascript; charset=UTF-8', so that the browser can display characters normally when accessing bundle file.

Test plan

  1. All unit tests pass.
  2. Utf8 characters are displayed normally in the browsers.

@facebook-github-bot facebook-github-bot added the CLA Signed label Aug 4, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2021

@feedthejim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 7, 2021

@feedthejim merged this pull request in 7d57801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants