Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): add Algolia search API key #726

Closed
wants to merge 4 commits into from
Closed

fix(website): add Algolia search API key #726

wants to merge 4 commits into from

Conversation

shortcuts
Copy link
Contributor

@shortcuts shortcuts commented Nov 3, 2021

Summary

This PR update the docusaurus config to expose the Algolia search API key.

note: Algolia search API keys can be disclosed publicly

Motivation

Search does not work on the production website.

Test plan

  • cd website
  • yarn start
  • Search

@facebook-github-bot facebook-github-bot added CLA Signed Shared with React Native Team labels Nov 3, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 9, 2022

@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shortcuts
Copy link
Contributor Author

shortcuts commented Feb 9, 2022

Since then, we've migrated to our new infra: https://docsearch.algolia.com/docs/migrating-from-legacy

Update credentials in 2b9306a to reflect that.

cc @rh389

@robhogan
Copy link
Contributor

robhogan commented Feb 9, 2022

Thanks @shortcuts and sorry this has taken so long for us to get around to!

I'm not personally familiar with our Algolia account - where do these values come from?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 9, 2022

@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shortcuts
Copy link
Contributor Author

shortcuts commented Feb 9, 2022

Thanks @shortcuts and sorry this has taken so long for us to get around to!

I'm not personally familiar with our Algolia account - where do these values come from?

No problem! Team members of the account have receive an email with those keys, you can also find them here https://www.algolia.com/account/api-keys/all?applicationId=T38HJZTD87

edit: I only see @cpojer as team members of this app. Should I add you?

@robhogan
Copy link
Contributor

robhogan commented Feb 9, 2022

I only see @cpojer as team members of this app. Should I add you?

Ah, yes, please - me and @motiz88. I'll email you.

ericanderson added a commit to ericanderson/metro that referenced this issue Feb 9, 2022
* upstream/main:
  Use node devtools url (facebook#761)
  Publish 0.68.0
  fix(website): add Algolia search API key (facebook#726)
  Change github actions trigger to use `main` branch (facebook#769)
  RN preset: support async iterators, for await of (facebook#747)
  Deploy 0.171.0 to xplat
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this issue Mar 14, 2022
Summary:
**Summary**

This PR update the docusaurus config to expose the Algolia search API key.

_note: Algolia search API keys can be disclosed publicly_

**Motivation**

Search does not work on the production website.

**Test plan**

- `cd website`
- `yarn start`
- Search

Pull Request resolved: facebook#726

Reviewed By: motiz88

Differential Revision: D34105655

Pulled By: rh389

fbshipit-source-id: 6a9fda7e92ff27ddbf5212cca72c138ec3672f56
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this issue Apr 21, 2022
Summary:
**Summary**

This PR update the docusaurus config to expose the Algolia search API key.

_note: Algolia search API keys can be disclosed publicly_

**Motivation**

Search does not work on the production website.

**Test plan**

- `cd website`
- `yarn start`
- Search

Pull Request resolved: facebook#726

Reviewed By: motiz88

Differential Revision: D34105655

Pulled By: rh389

fbshipit-source-id: 6a9fda7e92ff27ddbf5212cca72c138ec3672f56
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this issue Apr 22, 2022
Summary:
**Summary**

This PR update the docusaurus config to expose the Algolia search API key.

_note: Algolia search API keys can be disclosed publicly_

**Motivation**

Search does not work on the production website.

**Test plan**

- `cd website`
- `yarn start`
- Search

Pull Request resolved: facebook#726

Reviewed By: motiz88

Differential Revision: D34105655

Pulled By: rh389

fbshipit-source-id: 6a9fda7e92ff27ddbf5212cca72c138ec3672f56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Shared with React Native Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants