Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Enable findbugs and PMD

  • Loading branch information...
commit 3a9069990e6f95c5ffcc4452bc675f93a0976307 1 parent 0d52c18
@andrewcox andrewcox authored
View
106 nifty-client/pom.xml
@@ -16,14 +16,16 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-parent</artifactId>
- <version>0.6.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-parent</artifactId>
+ <version>0.6.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
</parent>
<name>Nifty client</name>
@@ -35,53 +37,53 @@ limitations under the License.
</properties>
<dependencies>
- <dependency>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-core</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
-
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
- <optional>true</optional>
- </dependency>
-
- <dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>annotations</artifactId>
- </dependency>
-
- <dependency>
- <groupId>io.airlift</groupId>
- <artifactId>units</artifactId>
- </dependency>
-
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- </dependency>
-
- <dependency>
- <groupId>org.easymock</groupId>
- <artifactId>easymock</artifactId>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.testng</groupId>
- <artifactId>testng</artifactId>
- <scope>test</scope>
- </dependency>
+ <dependency>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-core</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.inject</groupId>
+ <artifactId>guice</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>annotations</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifactId>units</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.easymock</groupId>
+ <artifactId>easymock</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.testng</groupId>
+ <artifactId>testng</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
View
2  nifty-client/src/main/java/com/facebook/nifty/client/AbstractClientChannel.java
@@ -337,7 +337,7 @@ public void run(Timeout timeout) {
/**
* Used to create TimerTasks that will fire
*/
- private class IoThreadBoundTimerTask implements TimerTask {
+ private static class IoThreadBoundTimerTask implements TimerTask {
private final NiftyClientChannel channel;
private final TimerTask timerTask;
View
8 nifty-client/src/main/java/com/facebook/nifty/client/TNiftyAsyncClientTransport.java
@@ -141,6 +141,8 @@ else if (e instanceof ChannelStateEvent) {
listener.onChannelClosedOrDisconnected(ctx.getChannel());
}
break;
+ default:
+ break;
}
}
else if (e instanceof ExceptionEvent) {
@@ -152,10 +154,8 @@ else if (e instanceof ExceptionEvent) {
private void messageReceived(ChannelHandlerContext ctx, MessageEvent e)
{
- if (e.getMessage() instanceof ChannelBuffer) {
- if (listener != null) {
- listener.onFrameRead(ctx.getChannel(), (ChannelBuffer) e.getMessage());
- }
+ if (e.getMessage() instanceof ChannelBuffer && listener != null) {
+ listener.onFrameRead(ctx.getChannel(), (ChannelBuffer) e.getMessage());
}
// drop it
}
View
7 nifty-client/src/main/java/com/facebook/nifty/client/socks/SocksProtocols.java
@@ -15,6 +15,7 @@
*/
package com.facebook.nifty.client.socks;
+import com.google.common.base.Charsets;
import org.jboss.netty.buffer.ChannelBuffer;
import org.jboss.netty.buffer.ChannelBuffers;
@@ -40,7 +41,7 @@ public static ChannelBuffer createSocks4packet(InetAddress address, int port)
if (address == null) {
throw new IllegalArgumentException("address is null");
}
- byte[] userBytes = System.getProperty("user.name", "").getBytes();
+ byte[] userBytes = System.getProperty("user.name", "").getBytes(Charsets.ISO_8859_1);
ChannelBuffer handshake = ChannelBuffers.dynamicBuffer(9 + userBytes.length);
handshake.writeByte(SOCKS_VERSION_4); // SOCKS version
handshake.writeByte(CONNECT); // CONNECT
@@ -56,8 +57,8 @@ public static ChannelBuffer createSock4aPacket(String hostName, int port)
if (hostName == null) {
throw new IllegalArgumentException("hostName is null");
}
- byte[] userBytes = System.getProperty("user.name", "").getBytes();
- byte[] hostNameBytes = hostName.getBytes();
+ byte[] userBytes = System.getProperty("user.name", "").getBytes(Charsets.ISO_8859_1);
+ byte[] hostNameBytes = hostName.getBytes(Charsets.ISO_8859_1);
ChannelBuffer handshake = ChannelBuffers.dynamicBuffer(10 + userBytes.length + hostNameBytes.length);
handshake.writeByte(SOCKS_VERSION_4); // SOCKS version
handshake.writeByte(CONNECT); // CONNECT
View
104 nifty-core/pom.xml
@@ -16,13 +16,15 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-parent</artifactId>
- <version>0.6.0-SNAPSHOT</version>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-parent</artifactId>
+ <version>0.6.0-SNAPSHOT</version>
</parent>
<name>Nifty Core</name>
@@ -34,52 +36,52 @@ limitations under the License.
</properties>
<dependencies>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.google.inject.extensions</groupId>
- <artifactId>guice-multibindings</artifactId>
- </dependency>
-
- <dependency>
- <groupId>io.airlift</groupId>
- <artifactId>units</artifactId>
- </dependency>
-
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- </dependency>
-
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
- <optional>true</optional>
- </dependency>
-
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </dependency>
-
- <dependency>
- <groupId>org.easymock</groupId>
- <artifactId>easymock</artifactId>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.testng</groupId>
- <artifactId>testng</artifactId>
- <scope>test</scope>
- </dependency>
+ <dependency>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.inject</groupId>
+ <artifactId>guice</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.google.inject.extensions</groupId>
+ <artifactId>guice-multibindings</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifactId>units</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ <optional>true</optional>
+ </dependency>
+
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.easymock</groupId>
+ <artifactId>easymock</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.testng</groupId>
+ <artifactId>testng</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</project>
View
143 nifty-examples/pom.xml
@@ -16,13 +16,15 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-parent</artifactId>
- <version>0.6.0-SNAPSHOT</version>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-parent</artifactId>
+ <version>0.6.0-SNAPSHOT</version>
</parent>
<name>Examples</name>
@@ -34,70 +36,83 @@ limitations under the License.
</properties>
<dependencies>
- <dependency>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-core</artifactId>
- </dependency>
- <dependency>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-client</artifactId>
- </dependency>
+ <dependency>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-client</artifactId>
+ </dependency>
- <dependency>
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- </dependency>
- <dependency>
- <groupId>io.airlift</groupId>
- <artifactId>units</artifactId>
- </dependency>
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifactId>units</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty</artifactId>
+ </dependency>
- <dependency>
- <groupId>javax.inject</groupId>
- <artifactId>javax.inject</artifactId>
- </dependency>
- <dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
- </dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- <scope>runtime</scope>
- </dependency>
- <dependency>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- <scope>runtime</scope>
- </dependency>
- <dependency>
- <groupId>org.testng</groupId>
- <artifactId>testng</artifactId>
- <scope>test</scope>
- </dependency>
+ <dependency>
+ <groupId>javax.inject</groupId>
+ <artifactId>javax.inject</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.inject</groupId>
+ <artifactId>guice</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <scope>runtime</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.testng</groupId>
+ <artifactId>testng</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <configuration>
- <forkMode>always</forkMode>
- </configuration>
- </plugin>
- </plugins>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <forkMode>always</forkMode>
+ </configuration>
+ </plugin>
+
+ <!-- Configure PMD plugin to skip checking of thrift-generated files -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-pmd-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/scribe.java</exclude>
+ <exclude>**/LogEntry.java</exclude>
+ <exclude>**/ResultCode.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
</build>
</project>
View
105 nifty-load-tester/pom.xml
@@ -16,13 +16,15 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-parent</artifactId>
- <version>0.6.0-SNAPSHOT</version>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-parent</artifactId>
+ <version>0.6.0-SNAPSHOT</version>
</parent>
<name>Load tester</name>
@@ -34,30 +36,30 @@ limitations under the License.
</properties>
<dependencies>
- <dependency>
- <groupId>com.facebook.nifty</groupId>
- <artifactId>nifty-core</artifactId>
- </dependency>
- <dependency>
- <groupId>io.airlift</groupId>
- <artifactId>bootstrap</artifactId>
- </dependency>
- <dependency>
- <groupId>io.airlift</groupId>
- <artifactId>configuration</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.thrift</groupId>
- <artifactId>libthrift</artifactId>
- </dependency>
- <dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-api</artifactId>
- </dependency>
- <dependency>
- <groupId>com.google.inject</groupId>
- <artifactId>guice</artifactId>
- </dependency>
+ <dependency>
+ <groupId>com.facebook.nifty</groupId>
+ <artifactId>nifty-core</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifactId>bootstrap</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifactId>configuration</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.inject</groupId>
+ <artifactId>guice</artifactId>
+ </dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty</artifactId>
@@ -65,27 +67,30 @@ limitations under the License.
</dependencies>
<build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <configuration>
- <filters>
- <filter>
- <!-- exclude old org.jboss.netty classes in favor of io.netty -->
- <artifact>org.jboss.netty:netty</artifact>
- <excludes>
- <exclude>org/jboss/netty/**</exclude>
- </excludes>
- </filter>
- </filters>
- <transformers>
- <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
- <mainClass>com.facebook.nifty.perf.NiftyLoadTester</mainClass>
- </transformer>
- </transformers>
- </configuration>
- </plugin>
- </plugins>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <mainClass>com.facebook.nifty.perf.NiftyLoadTester</mainClass>
+ </transformer>
+ </transformers>
+ </configuration>
+ </plugin>
+
+ <!-- Configure PMD plugin to skip checking of thrift-generated files -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-pmd-plugin</artifactId>
+ <configuration>
+ <excludes>
+ <exclude>**/LoadTest.java</exclude>
+ <exclude>**/LoadError.java</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
</build>
</project>
View
1  nifty-load-tester/src/main/java/com/facebook/nifty/perf/LoadTestHandler.java
@@ -102,6 +102,7 @@ public void burn(long microseconds) {
burnImpl(microseconds);
}
+ @SuppressWarnings("PMD.EmptyWhileStmt")
private void burnImpl(long microseconds) {
long end = System.nanoTime() + microseconds * 1000;
while (System.nanoTime() < end) {}
View
33 pom.xml
@@ -16,7 +16,9 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
@@ -42,9 +44,6 @@ limitations under the License.
<!-- it dependends on airlift, which is 1.7 only. -->
<!-- <project.build.targetJdk>1.6</project.build.targetJdk> -->
- <fb.check.fail-pmd>false</fb.check.fail-pmd>
- <fb.check.fail-findbugs>false</fb.check.fail-findbugs>
-
<dep.airlift.version>0.70</dep.airlift.version>
</properties>
@@ -68,14 +67,14 @@ limitations under the License.
<connection>scm:git:git@github.com:facebook/nifty.git</connection>
<developerConnection>scm:git:git@github.com:facebook/nifty.git</developerConnection>
<url>https://github.com/facebook/nifty</url>
- <tag>HEAD</tag>
- </scm>
+ <tag>HEAD</tag>
+ </scm>
<distributionManagement>
- <site>
- <id>github-project-site</id>
- <url>gitsite:git@github.com/facebook/nifty.git</url>
- </site>
+ <site>
+ <id>github-project-site</id>
+ <url>gitsite:git@github.com/facebook/nifty.git</url>
+ </site>
</distributionManagement>
<dependencyManagement>
@@ -167,6 +166,20 @@ limitations under the License.
</execution>
</executions>
</plugin>
+
+ <!-- Configure findbugs plugin to skip checking of thrift-generated files -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>findbugs-maven-plugin</artifactId>
+ <configuration>
+ <!--
+ NOTE: It would make more sense to have an exclude filter file per sub-module
+ but findbugs-maven-plugin has a bug that it will continue using the first
+ filter file it saw for the rest of the mvn process (even in different sub-modules).
+ -->
+ <excludeFilterFile>src/findbugs/findbugs-exclude-filter.xml</excludeFilterFile>
+ </configuration>
+ </plugin>
</plugins>
</pluginManagement>
<plugins>
View
43 src/findbugs/findbugs-exclude-filter.xml
@@ -0,0 +1,43 @@
+<?xml version="1.0"?>
+<!--
+
+ Copyright (C) 2012-2013 Facebook, Inc.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<FindBugsFilter>
+ <!-- nifty-examples excludes -->
+ <Match>
+ <Class name="com.facebook.nifty.test.scribe"/>
+ </Match>
+ <Match>
+ <Class name="~com\.facebook\.nifty\.test\.scribe\$.*"/>
+ </Match>
+ <Match>
+ <Class name="com.facebook.nifty.test.LogEntry"/>
+ </Match>
+ <Match>
+ <Class name="com.facebook.nifty.test.ResultCode"/>
+ </Match>
+ <!-- nifty-load-tester excludes -->
+ <Match>
+ <Class name="com.facebook.nifty.perf.LoadTest"/>
+ </Match>
+ <Match>
+ <Class name="com.facebook.nifty.perf.LoadError"/>
+ </Match>
+ <Match>
+ <Class name="~com\.facebook\.nifty\.perf\.LoadTest\$.*"/>
+ </Match>
+</FindBugsFilter>
Please sign in to comment.
Something went wrong with that request. Please try again.