Move maxFrameSize off of NiftyClient and into connectSync/connectAsync #40

Merged
merged 1 commit into from Feb 8, 2013

Projects

None yet

2 participants

@andrewcox
Contributor

This makes it easier to integrate into the swift client configuration settings, which are per client type. The expected max size for a frame will be different depending on the type of service.

(Also changing default max frame size to 16 MB instead of 1 MB, as several of our services return more than 1 MB on a regular basis.)

@andrewcox andrewcox Move max frame size off of NiftyClient and into connectSync/connectAs…
…ync parameters

This makes it easier to integrate into the swift client configuration settings, which are per client type. The expected max size for a frame will be different depending on the type of service.

Also changing default max frame size to 16 MB instead of 1 MB, as several of our services return more than 1 MB on a regular basis.
7e3be79
@andrewcox andrewcox referenced this pull request in facebook/swift Feb 8, 2013
Closed

Remove ThriftClientManagerProvider #60

@dain
Contributor
dain commented Feb 8, 2013

Looks good.

@andrewcox andrewcox merged commit 7e3be79 into facebook:master Feb 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment