Permalink
Switch branches/tags
Commits on Nov 9, 2018
  1. Fix remote project deserialization

    matthewwithanm authored and facebook-github-bot committed Nov 9, 2018
    Summary:
    These are remote URIs and `resolve()` doesn't do what you'd expect.
    
    Previously this worked because `getSpecification()` didn't return the remote URIs.
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12990347
    
    fbshipit-source-id: ff7fc6281157a65f34f31858c340d3587993e0f2
Commits on Nov 7, 2018
  1. Make sure that names never overflow selection

    matthewwithanm authored and facebook-github-bot committed Nov 7, 2018
    Summary:
    Phew! Okay, here's the deal:
    
    1. Everything inside of the scrollable container will change the size of the scrollable area. We can't figure out any way (transforms, negative positioning, etc) around that.
    2. If we put our selection inside of the scrollable container, it will affect the scrollable area. We want the selection indicator to be as wide as the scrollable area. So to measure that, we'd have to hide the selection indicator, measure the container, then show the indicator again. This is costly.
    3. If we put the selection indicator outside of the scrollable area, we can change its size without affecting the size of the scrollable area. (Also, it makes measurement simpler.) This sounds good and is the approach this commit takes, but…
    4. That means we need to manually align the selection indicator with the selected entry. To get that, we have to ask (react-virtualized's) List.
    
    Reviewed By: captbaritone
    
    Differential Revision: D12937324
    
    fbshipit-source-id: b814285386b33b4f92cb6c9b6993efa01559d169
Commits on Nov 2, 2018
  1. Ensure FileTreeEntryComponent rerenders on propchange

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary: Fixes the bug that matthewwithanm noticed in D12814538
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12892085
    
    fbshipit-source-id: 9aef7c84824dde3645b5db0997b9d9983ca69199
  2. Kill conf

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary: die, conf, die
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12814538
    
    fbshipit-source-id: 119072762a6f68ddd6027b7358db5f8a3446b902
  3. Move all conf properties to state

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary: In preparation for killing it. Done separately for ease of review.
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12814540
    
    fbshipit-source-id: 1d067bc7c33b12a34fcf014856b9e91514b7c9e9
  4. Convert focus and selection selectors to function-returners

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Reviewed By: wbinnssmith
    
    Differential Revision: D12814537
    
    fbshipit-source-id: 58dc2a2bc6f6b442164ef5612fd693ead739f088
  5. Add more memoization to selectors

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary:
    Creating the nested functions on every call is (noticeably!) expensive.
    
    Also, one actor (`getNodeIsContainer()`) can cause all of its dependent selectors to be updated every time, which is pretty hard to debug!
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12814536
    
    fbshipit-source-id: fd82fb4d9e518b55389a934cd715c4026d75a53e
  6. Kill MemoizedFieldsDeriver

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary:
    Move all of these to selectors.
    
    NOTE: Perf is pretty bad with this. That's fixed with the next commit.
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12814539
    
    fbshipit-source-id: e0927abfb42d7ba12c9ebc95fe0f4757827a63ae
  7. Move derived value access to selectors

    matthewwithanm authored and facebook-github-bot committed Nov 2, 2018
    Summary: Another step towards removing the expensive `updateConf()` operation.
    
    Reviewed By: wbinnssmith
    
    Differential Revision: D12813393
    
    fbshipit-source-id: 3d26e151735d652f1634150ad1d9df61064f2062