Enable Control Flow Guard on Windows #2986

Merged
merged 1 commit into from Feb 11, 2017

Conversation

Projects
None yet
3 participants
@yying
Contributor

yying commented Feb 8, 2017

This adds the compiler and linker flags necessary to enable control flow guard on the Windows build of osquery.

@theopolis

This comment has been minimized.

Show comment
Hide comment
@theopolis

theopolis Feb 9, 2017

Contributor

So if this is passing our compile and unit tests, does that meaning we're also passing the CFI checks?

And if this is enabled for the default compile/link, are we adding any additional overhead? If so, could we gate this to debug builds?

Contributor

theopolis commented Feb 9, 2017

So if this is passing our compile and unit tests, does that meaning we're also passing the CFI checks?

And if this is enabled for the default compile/link, are we adding any additional overhead? If so, could we gate this to debug builds?

@theopolis

This comment has been minimized.

Show comment
Hide comment
@theopolis

theopolis Feb 9, 2017

Contributor

NB: I'm 100% OK with this being enabled for all runtime binaries if it makes them safer.

Contributor

theopolis commented Feb 9, 2017

NB: I'm 100% OK with this being enabled for all runtime binaries if it makes them safer.

@theopolis theopolis merged commit d5cb6a3 into facebook:master Feb 11, 2017

4 checks passed

Code Audit Build finished.
Details
Linux Build finished.
Details
Windows Build finished.
Details
macOS/OS X Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment