New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected size in block_devices on darwin, linux (#3538) #3539

Merged
merged 1 commit into from Aug 8, 2017

Conversation

Projects
None yet
5 participants
@vishwa35
Contributor

vishwa35 commented Aug 7, 2017

This should fix the issues from #3538. Am open to modifying this to display size in bytes, but left it in block units to preserve current Linux implementation.

@muffins

This comment has been minimized.

Contributor

muffins commented Aug 7, 2017

ok to test

@osqueryer

This comment has been minimized.

Collaborator

osqueryer commented Aug 7, 2017

🙅 The commit 7078819 (Job results: 2184) failed the code audit or documentation test.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Aug 7, 2017

@vishwa35 updated the pull request - view changes

@osqueryer

This comment has been minimized.

Collaborator

osqueryer commented Aug 8, 2017

🙅 The commit 5b3c0b0 (Job results: 2185) failed the code audit or documentation test.

@facebook-github-bot

This comment has been minimized.

facebook-github-bot commented Aug 8, 2017

@vishwa35 updated the pull request - view changes

@theopolis

This comment has been minimized.

Contributor

theopolis commented Aug 8, 2017

LGTM! Thanks!

@theopolis theopolis merged commit c54c6e6 into facebook:master Aug 8, 2017

2 checks passed

Code Audit Build finished.
Details
Windows Build finished.
Details

uptycs-nishant pushed a commit to uptycs-nishant/osquery that referenced this pull request Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment