New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firehose/Kinesis support to Windows #3641

Merged
merged 4 commits into from Sep 3, 2017

Conversation

Projects
None yet
3 participants
@alessandrogario
Contributor

alessandrogario commented Sep 3, 2017

List of changes

  • Updated the PowerShell script that generates the aws-sdk-cpp nupkg file to support the latest version (1.1.44).
  • Disabled support for AWS credential profiles when running under Windows.
  • A couple of small fixes to the tests for the AWS utilities.

Notes

The Aws::Auth::InstanceProfileCredentialsProvider causes a crash when enabled on Windows. I have disabled it for now, and would like to have some feedback.

alessandrogario added some commits Sep 1, 2017

aws_kinesis/aws_firehose: Disabled profile support for Windows (see d…
…etails).

The Aws::Auth::InstanceProfileCredentialsProvider provider causes
a crash when used. I have decided to disable it when compiling on
Windows.
@muffins

A couple of smaller nits, then I think we're good to fold this in, thanks!

aws_firehose/aws_kinesis: Code review changes (see details).
Changes in the test module:

 o Use the setEnvVar/unsetEnvVar wrappers.
 o Do not use the preprocessor to disable test parts that
   are not compatible with Windows.
 o Fix the nupkg package version (remove the '-r1' suffix).
@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot commented Sep 3, 2017

@alessandrogario updated the pull request - view changes

@muffins

muffins approved these changes Sep 3, 2017

@muffins muffins merged commit 6489c8b into facebook:master Sep 3, 2017

uptycs-nishant pushed a commit to uptycs-nishant/osquery that referenced this pull request Oct 28, 2017

@alessandrogario alessandrogario deleted the trailofbits:alessandro/bugfix/aws-windows-support branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment