Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Write support for tables implemented from extensions #4094
This PR adds support for writable extension tables by providing an xUpdate sqlite3 implementation.
Write support for core/built-in tables is NOT implemented, and will not work.
This is a small demo for the following example: osquery/examples/example_writable_table.cpp
I've marked a few things as what I think are API Changes which might break other people's building of things that use the osquery SDK (at least I think that's what would happen). This is not a huge problem but it is something we want to make sure we're not doing flippantly.
Overall I like this a lot, this is going to be a super cool feature to have and will provide a lot of value.
1 similar comment
Ok, I left myself some pointers for a larger review later.
I think this approach works. I want to be extra-sure about the keys (their names) used in serialization.
I've rebased and fixed the issues that have been mentioned; the remaining comments are personal notes/bookmarks that Ted has left for his review during QueryCon. I don't think he is requesting for any change, but correct me if I'm wrong!