fix #4810 syslog pipe hang #5259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
|
Is there any reason why this has not been merged? |
ycooper
added a commit
to ycooper/osquery
that referenced
this pull request
Aug 27, 2019
Refactored osquery#5259 to version 4.0
ycooper
added a commit
to ycooper/osquery
that referenced
this pull request
Aug 29, 2019
Refactored osquery#5259 to version 4.0
|
Closing. I'm going to open a new PR. |
|
Heads up, there should be a fix for this in master now #6539. Thanks for the work here, it's the main inspiration for the landed change; and sorry for leaving this unaddressed for so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for syslog issue in V3 branches . This implementation opens pipe using NONBLOCK and uses select and buffered read of lines, rather than waiting on gets() or getline() like existing code.
#4810