* h_program-lang/dependencies_matrix_code.ml: todos

facebookarchive · Sep 11, 2012 · 63ef908 · 63ef908
1 parent e93171a
commit 63ef908
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/h_program-lang/dependencies_matrix_code.ml b/h_program-lang/dependencies_matrix_code.ml
@@ -135,6 +135,10 @@ let build_with_tree2 tree full_matrix_opt g =
           )
         end
       );
+  (* todo: the full matrix contains actually only the top k nodes,
+   * so the name_to_i may fail below. Need to compute ...
+   * go through all the edges under and reproject.
+   *)
   | Some fulldm ->
       for i = 0 to n - 1 do
         for j = 0 to n - 1 do
@@ -276,6 +280,9 @@ let build tree full_matrix_opt g =
 
 let threshold_nodes_full_matrix = 100000
 
+(* todo: intelligent split of the tree? to avoid outliers? 
+ * have a quota per subtree?
+ *)
 let top_nodes_of_graph_until_threshold g =
 
   let res = ref [] in