Skip to content
This repository
branch: master

Apr 11, 2014

  1. phooji

    [abstract interpreter] support containers

    Summary:
    Per title. Similar to D1268141 and D1262073. Since
    our model for arrays already covers most of this,
    just use that in general.
    
    Also: some hardcoded support for copying operations.
    This is pretty much explicitly wrong (copies the
    reference, not the data), but it makes more unit
    tests pass, so clearly the ends justify the means.
    
    Also: this will end up treating `Set { 1, 2, 3}` as
    if it is ordered.
    
    Test Plan: Upcoming integration tests in a separate diff.
    
    Reviewers: pad, julienv
    
    Reviewed By: pad
    
    CC: collingreene
    
    Differential Revision: https://phabricator.fb.com/D1270354
    
    Task ID: 4081629
    authored April 09, 2014
  2. phooji

    [abstract interpreter] re-enable foreach stuff

    Summary:
    Similar to D1262073: minor adjustments because the shape of
    ast_php_simple has changed since this was last in production.
    
    Add an explicit exception type that gets thrown when we see
    a foreach with a shape we don't (yet?) handle.
    
    Test Plan: Will add corresponding integration tests.
    
    Reviewers: pad, julienv
    
    Reviewed By: pad
    
    CC: collingreene
    
    Differential Revision: https://phabricator.fb.com/D1268141
    
    Task ID: 4081629
    authored April 08, 2014

Apr 10, 2014

  1. Yoann Padioleau

    [stags] escape correctly / in vi generated TAGS file

    Summary: Hanson reported this bug
    
    Test Plan: unit test included
    
    Reviewers: hansonw, pieter, jcreed, bill, erling
    
    Reviewed By: bill
    
    CC: bryano
    
    Differential Revision: https://phabricator.fb.com/D1270200
    authored April 10, 2014
  2. Yoann Padioleau

    Merge branch 'master' of github.com:facebook/pfff

    authored April 10, 2014
  3. Avik Chaudhuri

    interface

    Summary:
    Support interface declarations a la TypeScript. This allows us to codify
    type specifications for JS primitives (see test).
    
    Test Plan: make tests
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: bryano, bhosmer
    
    Differential Revision: https://phabricator.fb.com/D1266866
    authored April 10, 2014
  4. Avik Chaudhuri

    spread

    Summary:
    Added support for spread arguments f(...[1,2,3]).
    
    Also updated a rule for parsing arrow functions, and added some explanations in
    conflicts.txt on why the treatment of arrow functions is limited.
    
    Test Plan:
    make tests
    ./pfff -parse_js ~/www/
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: bhosmer, bryano
    
    Differential Revision: https://phabricator.fb.com/D1264313
    authored April 10, 2014
  5. Yoann Padioleau

    * lang_js/parsing/parse_js.ml: parse_string, dead but can be useful

    authored April 10, 2014

Apr 08, 2014

  1. Yoann Padioleau

    Merge branch 'master' of github.com:facebook/pfff

    authored April 08, 2014
  2. Yoann Padioleau

    * lang_cpp/analyze/highlight_cpp.ml: add IMPORTANT: special comment

    authored April 08, 2014
  3. bill fumerola

    [pfff] optionally include hack (.hhi) files when searching for php files

    Summary: defaults to off
    
    Test Plan:
    elsewhere:
    
          lang=ml
          Tags_php.php_defs_of_files_or_dirs ~verbose:true ~include_hack:true
          (Lib_parsing_php.find_source_files_of_dir_or_files [dir] ~include_hack:true )
    
    ran locally to validate tags generated:
    ./stags -lang hack /var/www/hack -o /tmp/derp
    
    Reviewers: pad, jwatzman, julienv, eletuchy
    
    Reviewed By: pad
    
    CC: jan, joelp
    
    Differential Revision: https://phabricator.fb.com/D1263293
    authored April 07, 2014
  4. Yoann Padioleau

    * changes.txt:

    authored April 08, 2014
  5. phooji

    [abstract interpreter] re-enable handling of arrays

    Summary:
    Mostly mechanical. This adds back in our original modeling of
    arrays. String literals are mapped precisely, while integer indices
    are less precise (based on my superficial understanding).
    
    Test Plan: Will add corresponding integration tests.
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: collingreene
    
    Differential Revision: https://phabricator.fb.com/D1262073
    authored April 06, 2014
  6. phooji

    [pfff] parse some java from a string

    Summary: See title.
    
    Test Plan: testinprod
    
    Reviewers: pad
    
    Reviewed By: pad
    
    Differential Revision: https://phabricator.fb.com/D1262068
    authored March 28, 2014
  7. Yoann Padioleau

    * lang_clang/analyze/graph_code_clang.ml: improve conf, add propagate…

    … defs to decl
    authored April 07, 2014
  8. Yoann Padioleau

    code_map: highlight searched entity

    authored April 07, 2014

Apr 07, 2014

  1. Avik Chaudhuri

    optional params

    Summary:
    Add support for optional params and optional param types a la ES6/TypeScript.
    
    Optional params have two forms, with default values (x=42) and without (x?).
    Optional param types have one form, (x?:number).
    
    Also added type support for rest params.
    
    Test Plan:
    make tests
    ./pfff -parse_js ~/www/
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: bhosmer, bryano
    
    Differential Revision: https://phabricator.fb.com/D1263340
    authored April 07, 2014
  2. Avik Chaudhuri

    JS parser support for object method types

    Summary:
    The JS parser now understands object method types in addition to object field types.
    For example, we can now write { ... f(x:string):number; ... } (a la TypeScript)
    in addition to { ... f: (x:string)=>number, ... }
    
    The former style also accommodates generic types (see test).
    Unfortunately, the latter style does not, causing conflicts with JSX.
    This is fine, since TypeScript signatures prefer the former style.
    
    Since method types no longer benefit from colon separation between
    identifiers and their types, they may also conflict with other expression forms.
    In particular, we need to weaken the form of nominal types.
    This is also fine, since TypeScript also enforces restrictions on nominal types.
    
    Test Plan:
    make tests
    ./pfff -parse_js ~/www/
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: bhosmer, bryano
    
    Differential Revision: https://phabricator.fb.com/D1260979
    authored April 07, 2014
  3. Yoann Padioleau

    * changes.txt: misc

    authored April 07, 2014

Apr 05, 2014

  1. Yoann Padioleau

    * lang_cpp/parsing/unit_parsing_cpp.ml: add regression tests for C

    authored April 04, 2014
  2. Yoann Padioleau

    * lang_cpp/parsing/ast_cpp.ml: get rid of FinalDef

    authored April 04, 2014
  3. Yoann Padioleau

    * tests/c/parsing/typedef_proto2.c: handling

    authored April 04, 2014

Apr 04, 2014

  1. Yoann Padioleau

    * graph_code/graph_code.ml: todo

    authored April 04, 2014
  2. Yoann Padioleau

    Merge branch 'master' of github.com:facebook/pfff

    authored April 04, 2014
  3. Yoann Padioleau

    * tests/php/codegraph/class_field.php:

    authored April 04, 2014
  4. Yoann Padioleau

    * tests/php/parsing/type_hints_return.php:

    authored April 04, 2014
  5. Yoann Padioleau

    * skip_list.txt:

    authored April 04, 2014
  6. Avik Chaudhuri

    JS parser support for object methods

    Summary:
    Following ES6,
    enhanced the syntax of properties in object literals from fields of the form x: ..
    to fields and methods of x() { .. }
    
    Test Plan:
    make tests
    (added a test)
    
    Reviewers: pad
    
    Reviewed By: pad
    
    CC: bhosmer, bryano
    
    Differential Revision: https://phabricator.fb.com/D1258984
    authored April 04, 2014

Apr 03, 2014

  1. Yoann Padioleau

    * code_map/view2.ml: remove some menu

    authored April 02, 2014
  2. Yoann Padioleau

    * code_map/model2.ml: current_node_selected

    authored April 02, 2014

Apr 02, 2014

  1. Yoann Padioleau

    * h_program-lang/database_code.pl: ugly

    authored April 02, 2014
  2. Yoann Padioleau

    * main_codequery.ml: make it work ...

    authored April 02, 2014
  3. Yoann Padioleau

    Merge branch 'master' of github.com:facebook/pfff

    authored April 02, 2014

Apr 01, 2014

  1. Yoann Padioleau

    * globals/config_pfff.ml.in: bump version

    authored April 01, 2014
  2. Yoann Padioleau

    * tests/c/parsing/struct_unamed_kencc.c: handling it

    authored April 01, 2014
  3. Yoann Padioleau

    * tests/php/parsing/namespace.php:

    authored April 01, 2014
Something went wrong with that request. Please try again.