Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Feb 2, 2015
  1. @aryx
  2. @aryx
  3. @aryx
  4. @aryx

    * main_test.ml: -luisa

    aryx authored
  5. @aryx
  6. @aryx

    * main_codequery.ml: todo

    aryx authored
  7. @aryx
  8. @aryx

    * lang_c/parsing/ast_c.ml: misc

    aryx authored
  9. @aryx
  10. @aryx
  11. @aryx

    * main_sgrep.ml: related work

    aryx authored
Commits on Jan 31, 2015
  1. @elgenie

    [pfff] support abstract const declarations

    elgenie authored
    Summary:
    `abstract const` for classes is necessary to be able to
     safely deal with PHP-isms like `static::THE_CONST` and
     `$instance::THE_CONST`.
    
     Mostly shuffling ast nodes: there's entirely entirely too
     much code being churned in this diff.
    
    Test Plan: included test (possibly inadequate test coverage)
    
    Reviewers: jezng, andrewparoski, mqian, pieter
    
    Reviewed By: pieter
    
    Differential Revision: https://phabricator.fb.com/D1817448
    
    Signature: t1:1817448:1422688166:ddc4c8d4a3dbbde1c3dc24cb5862df02ab4459c3
  2. @elgenie

    [pfff] update spacing in prolog tests

    elgenie authored
    Summary:
    When running swipl 5.7, the (insignificant) whitespace in
     facts did not quite match up with what the tests were expecting
    
      > swipl --version
      SWI-Prolog version 5.7.11 for x86_64-linux
    
    Test Plan:
      make test (prolog tests now pass)
    
    Reviewers: andrewparoski, pieter
    
    Reviewed By: pieter
    
    Differential Revision: https://phabricator.fb.com/D1816838
    
    Signature: t1:1816838:1422670201:f3643b7ebccfd407bea23227a5c3fd4f5c382c3b
  3. @elgenie

    [pfff] parse hh async blocks

    elgenie authored
    Summary:
    The syntax `async { <body> }` is used to indicate an
     immediately executed short closure (aka lambda). Some AST
     manipulation is required to indicate that the parameter list and
     `==>` portions of the lambda have been omitted.
    
    Test Plan: included test
    
    Reviewers: pieter, mqian, andrewparoski, jezng, jan
    
    Reviewed By: jan
    
    Differential Revision: https://phabricator.fb.com/D1816822
    
    Signature: t1:1816822:1422667074:805bb5a4ce559b0192459ab6015b50df0d9be164
Commits on Jan 30, 2015
  1. @hansonw

    [pfff] Replace >> with "> >" in lambda typehints

    hansonw authored
    Summary:
    pad's parsing hack for ">>" doesn't know about lambda typehint contexts, so using ">>" in any lambda param typehint or return type typehint leads to a parsing error. Replace these properly.
    
    Also, I made the lambda typehint parse hack stop throwing errors - it just silently ignores things it doesn't understand now. I think this is preferable? The standard parse error will probably lead you to the approximate error location at least.
    
    Test Plan:
    Updated unit test, ran on all of `~/www`.
    
    These are the failures:
    ```
    1 /home/hansonw/www/flib/thrift/lib/fbcode/adsatlas/api/extif/atlas_api.thrift/atlas_api_types.php
    2 /home/hansonw/www/flib/intern/site/x/search/metrics/XInternNewsEventEvaluationQueriesPrecisionGeneratorController.php
    3 /home/hansonw/www/flib/groups/notifications/comment_mention/GroupCommentMentionNotificationSender.php
    4 /home/hansonw/www/flib/entity/query/core/filters/EntArgsBasedQueryFilter.php
    5 /home/hansonw/www/flib/js/mercury/MercuryConfig.php
    6 /home/hansonw/www/flib/notifications/renderers/fql_common/__tests__/NotifFQLRepresentationTestCase.php
    7 /home/hansonw/www/flib/third-party/php-openid/Auth/OpenID/Server.php
    8 /home/hansonw/www/flib/third-party/php-openid/Auth/OpenID/TrustRoot.php
    ```
    
    Upon inspection:
    - 1, 7, 8 are legitimate syntax errors
    - 4, 6 caused by some still unsupported unpacking syntax
    - 2, 3, 5 are caused by the new `async { }` syntax
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    Differential Revision: https://phabricator.fb.com/D1813353
    
    Signature: t1:1813353:1422571196:238f2d5aad28ce1c90bc71ac2f350f54d79ce2e3
Commits on Jan 21, 2015
  1. @aryx

    Merge pull request #106 from mtibben/patch-1

    aryx authored
    Fix MacOSX install instructions
  2. @mtibben

    Fix MacOSX install instructions

    mtibben authored
    Updates the MacOSX install instructions for installing brew dependencies.
    
    Added `camlp4` as it's required when calling `make depend`. And `ocaml` is now called `objective-caml`.
Commits on Jan 20, 2015
  1. @Stelian

    Fixed an issue where phar files are treated like php scripts

    Stelian authored
    Added 'is_php_fileame_phar' function to check against the phar files
    Reworked 'is_php_file' so it ignores phar files
Commits on Dec 23, 2014
  1. @phooji

    [pfff] move commons_graph to a separate directory

    phooji authored
    Summary:
    
    Looks like 378a73c wasn't
    quite match how the library is actually built. This moves
    the commons graph wrapper to a separate directory so that
    it's easier to build as a separate findlib package.
    
    This makes it easier to deal with some internal tooling that
    expects a single `.cmxa` and `.a` as a limitation.
    
    Test Plan:
    
      make clean
      make depend
      make
      make opt
      make uninstall-findlib
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  2. @phooji

    [pfff] commons: export additional interfaces

    phooji authored
    Summary:
    
    `Graph` is referenced in `graph_code` (unsurprisingly)
    
    Test Plan:
    
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  3. @phooji

    [pfff] export pretty_print_code

    phooji authored
    Summary:
    
    Almost there!
    
    Test Plan:
    
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed by: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  4. @phooji

    [pfff] add lang_php/pretty findlib

    phooji authored
    Test Plan:
    
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  5. @phooji

    [pfff] add json_out to exported symbols for jsonwheel

    phooji authored
    Summary:
    
    Similar to json_in; something references directly.
    
    Test Plan:
    
    make
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  6. @phooji

    [pfff] add commons.mli to exported interfaces for pfff/commons

    phooji authored
    Summary:
    
    There's some references to this in fb-only code, so make sure
    it's exposed.
    
    Test Plan:
    
      make
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  7. @phooji

    [pfff] h_program-lang fixup: more cmis

    phooji authored
    Summary:
    
    `Database_code` is referenced directly in a few places, and
    wasn't getting imported properly.
    
    Test Plan:
    
    make install-findlib; build something that uses `Database_code`
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  8. @phooji

    [pfff] export findlib target for lang_php/analyze/matcher

    phooji authored
    Summary:
    
    Same as the last couple; make this findlib-exportable so I can
    link directly against the individual build products rather than
    just one All of PFFF Blob.
    
    Test Plan:
    
      make install-findlib # from various directories
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  9. @phooji

    [pfff] export ast_php_simple.cmi

    phooji authored
    Summary:
    
    CMF depends directly on this file, and it doesn't have an mli,
    so we need to export this explicitly.
    
    Test Plan:
    
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  10. @phooji

    [pfff] export findlib target for lang_php/matcher

    phooji authored
    Summary:
    
    Similar to the last couple.
    
    Test Plan:
    
      make uninstall-findlib
      cd lang_php/matcher
      make install-findlib
      make uninstall-findlib
      cd ../..
      make install-findlib
      make uninstall-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  11. @phooji

    [pfff] export findlib target for h_version-control

    phooji authored
    Summary:
    
    Per title.
    
    Test Plan:
    
      make uninstall-findlib
      cd h_version-control
      make install-findlib
      make uninstall-findlib
      cd ..
      make install-findlib
      make uninstall-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  12. @phooji

    [pfff] minor Makefile fixes

    phooji authored
    Summary:
    
    jsonwheel seems to have incurred a last-minute typo, and needs
    to export json_in; export all mli for graph_code.
    
    Test Plan:
    
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
Commits on Dec 22, 2014
  1. @phooji

    [pfff] make install-findlib pick up graph_code and ocamlgraph

    phooji authored
    Summary:
    
    Looks like graph_code was missing a META file, and ocamlgraph was
    referring to a missing `graph.a` without the `ocaml` prefix.
    
    Test Plan:
    
    From the root:
    
      make uninstall-findlib
      make install-findlib # includes graph_code and ocamlgraph; succeeds
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  2. @phooji

    [pfff] add entity_code.mli to findlibs interface for h_program-lang

    phooji authored
    Summary:
    
    Title
    
    Test Plan:
    
      cd h_program-lang
      make uninstall-findlib
      make install-findlib # succeeds; lists `entity_code.mli`
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  3. @phooji

    [pfff] make lang_php/analyze/foundation findlib installable

    phooji authored
    Summary:
    
    Same approximate motivation as the previous round of this.
    
    Test Plan:
    
      make install-findlib
      make uninstall-findlib # from pfff ; pfff/lang_php/analyze ; pfff/lang_php/analyze/foundation
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  4. @phooji

    [pfff] add parallel.ml to exported interfaces for findlib

    phooji authored
    Summary:
    
    Need a direct dep on this.
    
    Test Plan:
    
      make uninstall-findlib
      make install-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
  5. @phooji

    [pfff] add install-findlib target for jsonwheel

    phooji authored
    Summary:
    
    Title.
    
    Test Plan:
    
      make install-findlib
      make uninstall-findlib
    
    Reviewers: pieter
    
    Reviewed By: pieter
    
    CC:
    
    Task ID: #
    
    Blame Rev:
Something went wrong with that request. Please try again.