Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Proposal] HTTP client class & interface for extensibility #4
Let's extract the HTTP-client specific code from
referenced this issue
May 1, 2014
Since #44 was shut down for now, let's get an injectable HTTP client handler.
But before I submit a PR, I'd like to propose that we ship the SDK with Guzzle as the default HTTP client implementation. I talked with @jeremeamia who heads up the SDK for AWS and he said the number 1 bug-causing PR-submitting functionality was their curl implementation. When they switched to Guzzle, all that headache went away.
I'd like to just rewrite all the HTTP client stuff on Guzzle with easy ways for a developer to tweak the HTTP client or inject their own handler. Just need a blessing.
Just a heads up. The PR is coming later today and it's quite a refactor of the HTTP client stuff. But definitely take a close look at it to see why it's better (because it's hella better!) =) I'll try to throw up a gist example of how a developer could implement Guzzle with it too. :)