Merge pull request #456 from OndraM/feature/drop-php-5.5

Drop PHP 5.5 support
php-webdriver · Aug 26, 2017 · 9482a3e · 9482a3e
2 parents 1c5e7f0 + cb1f8bd
commit 9482a3e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 10 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -3,7 +3,6 @@ sudo: false
 dist: trusty
 
 php:
-  - 5.5
   - 5.6
   - 7.0
   - 7.1

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 This project versioning adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
+### Changed
+- Drop PHP 5.5 support, the minimal required version of PHP is now PHP 5.6.
 
 ## 1.4.1 - 2017-04-28
 ### Fixed

diff --git a/lib/Support/Events/EventFiringWebDriver.php b/lib/Support/Events/EventFiringWebDriver.php
@@ -396,15 +396,14 @@ protected function newElement(WebDriverElement $element)
 
     /**
      * @param mixed $method
+     * @param mixed $arguments,...
      */
-    protected function dispatch($method)
+    protected function dispatch($method, ...$arguments)
     {
         if (!$this->dispatcher) {
             return;
         }
 
-        $arguments = func_get_args();
-        unset($arguments[0]);
         $this->dispatcher->dispatch($method, $arguments);
     }
 

diff --git a/lib/Support/Events/EventFiringWebDriverNavigation.php b/lib/Support/Events/EventFiringWebDriverNavigation.php
@@ -149,15 +149,14 @@ public function to($url)
 
     /**
      * @param mixed $method
+     * @param mixed $arguments,...
      */
-    protected function dispatch($method)
+    protected function dispatch($method, ...$arguments)
     {
         if (!$this->dispatcher) {
             return;
         }
 
-        $arguments = func_get_args();
-        unset($arguments[0]);
         $this->dispatcher->dispatch($method, $arguments);
     }
 

diff --git a/lib/Support/Events/EventFiringWebElement.php b/lib/Support/Events/EventFiringWebElement.php
@@ -392,14 +392,14 @@ protected function dispatchOnException(WebDriverException $exception)
 
     /**
      * @param mixed $method
+     * @param mixed $arguments,...
      */
-    protected function dispatch($method)
+    protected function dispatch($method, ...$arguments)
     {
         if (!$this->dispatcher) {
             return;
         }
-        $arguments = func_get_args();
-        unset($arguments[0]);
+
         $this->dispatcher->dispatch($method, $arguments);
     }