In order to support both Facebook internal use and acceptance in the broader community, and considering the slow current slow pace of development (last release tagged 7 months ago,) we should maintain an official community version which is allowed to grow on its own.
This way, the community can support current practices and interoperate better with other tools. Important bug-fixes can be made to both versions, and everyone could help review and improve the code. There are many forks, and some of that can be shared back for the benefit of all.
I've created a branch, community, which can become the default branch. How about we use that to comply with PSR-2 and add Namespaces, per #204 and #190, and make a 1.0 release?
Any thoughts on this approach?
I have a working version with namespaces here: https://github.com/opsbears/php-webdriver
Saves you some work, just search and replace as needed. :)
+1, though this would mean rewriting our tests (or at least doing lots of search & replace).
@OndraM Please do check my fork, it's all done.
I'm on board with this as well
@janoszen Why not prepare a PR?
Any requirements on the namespace part?
Just some thoughts:
I can do that fairly quickly if that is ok.
@0x20h I would suggest keeping the name WebDriver. It is also official name of the W3C standard..
@OndraM yep, absolutely. Thanks for the feedback!
I'm 👍 on all of those suggestions @0x20h @OndraM
OK guys, I have made the changes requested to my own repo (see above). It would need some real world testing, so if you have a project, feel free to jump on it. Feedback is also welcome.
Hey @janoszen, thanks for your work!
Just had a quick look at it.
I think you should keep the directory structure and create sub namespaces.
Yeah, that wasn't clear. I'll get this done as soon as I have some time.
OK, it's done, but I've done an insane amount of automatic refactoring, so getting a second pair of eyes on the code would be good before the PR.
FYI, our testsuite seems fine with your branch.
Let's move the discussion to the PR :)
Can we get that submitted as a PR against the community branch here?
I welcome this approach, as it allows for more centralized development.
I have one tiny PR to contribute: #217
Issue facebook/php-webdriver#212 - Moving forward
Implemented namespacing as discussed (needs testing)
Issue facebook/php-webdriver#212 - Moved classes to subnamespaces (ne…
…eds manual testing)
Ok, we did it!.. 👍