This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
setState within componentWillMount uses internal property update #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jun 21, 2018
src/react/components.js
Outdated
| @@ -218,16 +224,16 @@ export function createClassInstanceForFirstRenderOnly( | |||
| } | |||
| if (stateToUpdate instanceof ObjectValue) { | |||
| let newState = new ObjectValue(realm, realm.intrinsics.ObjectPrototype); | |||
| newState.makeFinal(); | |||
There was a problem hiding this comment.
How do we make it final and then immediately do an Object.assign to it? Seems inconsistent. I thought finals are treated as immutable.
Should we do this after it's fully initialized?
There was a problem hiding this comment.
Yes, you beat me to this, I changed it in my latest commit.
There was a problem hiding this comment.
@hermanventer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: none
As we're updating state on a final object, in this case
state, ensure we usehardModifyReactObjectPropertyBinding. Unblocks #2137.