Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplicative seasonality #264

Closed
wants to merge 6 commits into from

Conversation

@mszheng
Copy link

commented Jul 30, 2017

  • TODO: update win stan models
  • TODO: add tests
  • TODO: add notebook with examples
  • TODO: add functionality to R version
Add multiplicative seasonality
* TODO: update win stan models
* TODO: add tests
* TODO: add notebook with examples
* TODO: add functionality to R version
@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mszheng added 2 commits Jul 30, 2017
Add multiplicative seasonality
* TODO: update win stan models
* TODO: add tests
* TODO: add notebook with examples
* TODO: add functionality to R version

@mszheng mszheng force-pushed the mszheng:multiplicative-seasonality branch 5 times, most recently from b88a053 to 4b8d478 Nov 5, 2017

@mszheng mszheng force-pushed the mszheng:multiplicative-seasonality branch from 4b8d478 to 2614030 Nov 6, 2017

@bletham

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2018

I'm going to close this since we'll do it as an all-in-one model as we discussed, which will be much easier with the refactor in how the feature matrix is computed.

@bletham bletham closed this Feb 2, 2018

@mszheng

This comment has been minimized.

Copy link
Author

commented Feb 12, 2018

Ok, let me know if I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.