From c8e02c6c5b1ac62fdc2ce6a33b6b0f97a5a7f916 Mon Sep 17 00:00:00 2001
From: Zeina Migeed <migeedz@meta.com>
Date: Tue, 21 May 2024 11:42:50 -0700
Subject: [PATCH] Rename ClassDecorators to ExtractDataclassOptions in
 dataclassOptions

Summary:
We are going to expose all dataclass functionality to the typechecker. To do so, we must separate that functionality from attributeResolution.

In this diff, we will rename ClassDecorators to ExtractDataclassOptions.

Reviewed By: stroxler

Differential Revision: D57587117

fbshipit-source-id: 126c3d32ec722d90db71e6e76996ebd1c7c5915b
---
 source/analysis/attributeResolution.ml | 20 +++++++++++---------
 source/analysis/dataclassOptions.ml    |  2 +-
 source/analysis/dataclassOptions.mli   |  2 +-
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/source/analysis/attributeResolution.ml b/source/analysis/attributeResolution.ml
index 268e73235cb..344b49f613f 100644
--- a/source/analysis/attributeResolution.ml
+++ b/source/analysis/attributeResolution.ml
@@ -1614,7 +1614,7 @@ let apply
     | None -> []
     | Some
         {
-          ClassDecorators.init;
+          ExtractDataclassOptions.init;
           repr;
           eq;
           order;
@@ -1769,10 +1769,11 @@ let apply
         let split_parameters_by_keyword_only parameters =
           let keyword_only, not_keyword_only =
             List.partition_tf parameters ~f:(function
-                | { ClassDecorators.name = _; annotation = _; default = _; keyword_only } ->
+                | { ExtractDataclassOptions.name = _; annotation = _; default = _; keyword_only } ->
                 keyword_only)
           in
-          let dataclass_constructor_to_named { ClassDecorators.name; annotation; default; _ }
+          let dataclass_constructor_to_named
+              { ExtractDataclassOptions.name; annotation; default; _ }
               : Type.t Callable.RecordParameter.named
             =
             { name; annotation; default }
@@ -1814,13 +1815,13 @@ let apply
                 in
                 let rec override_existing_parameters
                     (unchecked_parameters :
-                      Type.t ClassDecorators.dataclass_constructor_parameter list)
+                      Type.t ExtractDataclassOptions.dataclass_constructor_parameter list)
                   =
                   match unchecked_parameters with
                   | [] ->
                       [
                         {
-                          ClassDecorators.name;
+                          ExtractDataclassOptions.name;
                           annotation;
                           default = Option.is_some init_value;
                           keyword_only;
@@ -1974,21 +1975,22 @@ let apply
   let dataclass_attributes () =
     (* TODO (T43210531): Warn about inconsistent annotations
      * TODO (T131540506): Decouple dataclass options from other options *)
-    generate_attributes ~options:(ClassDecorators.dataclass_options ~queries)
+    generate_attributes ~options:(ExtractDataclassOptions.dataclass_options ~queries)
   in
   let attrs_attributes () =
     (* TODO (T41039225): Add support for other methods
      * TODO (T129741558): support type annotations in attr *)
-    generate_attributes ~options:(ClassDecorators.attrs_attributes ~queries)
+    generate_attributes ~options:(ExtractDataclassOptions.attrs_attributes ~queries)
   in
   let dataclass_transform_attributes () =
     generate_attributes
-      ~options:(ClassDecorators.options_from_custom_dataclass_transform_decorator ~queries)
+      ~options:(ExtractDataclassOptions.options_from_custom_dataclass_transform_decorator ~queries)
   in
   let dataclass_transform_class_attributes () =
     generate_attributes
       ~options:
-        (ClassDecorators.options_from_custom_dataclass_transform_base_class_or_metaclass ~queries)
+        (ExtractDataclassOptions.options_from_custom_dataclass_transform_base_class_or_metaclass
+           ~queries)
   in
   dataclass_attributes ()
   @ attrs_attributes ()
diff --git a/source/analysis/dataclassOptions.ml b/source/analysis/dataclassOptions.ml
index 988d882eccb..926dc6a2196 100644
--- a/source/analysis/dataclassOptions.ml
+++ b/source/analysis/dataclassOptions.ml
@@ -50,7 +50,7 @@ module Queries = struct
     Type.split annotation |> fst |> Type.primitive_name >>= get_class_summary
 end
 
-module ClassDecorators = struct
+module ExtractDataclassOptions = struct
   type options = {
     init: bool;
     repr: bool;
diff --git a/source/analysis/dataclassOptions.mli b/source/analysis/dataclassOptions.mli
index e8faa87ff5b..1c03df0bd85 100644
--- a/source/analysis/dataclassOptions.mli
+++ b/source/analysis/dataclassOptions.mli
@@ -45,7 +45,7 @@ module Queries : sig
   val class_summary_for_outer_type : t -> Type.t -> ClassSummary.t Ast.Node.t option
 end
 
-module ClassDecorators : sig
+module ExtractDataclassOptions : sig
   type options = {
     init: bool;
     repr: bool;