From 97b9297268bcfa22f0116d7f5acbdaaacfd9fc75 Mon Sep 17 00:00:00 2001
From: Kyle Into <kylei@meta.com>
Date: Thu, 9 Jul 2026 10:20:58 -0700
Subject: [PATCH 1/2] getComputedType: document gaps

Summary: See last diff for context. reproduces https://github.com/facebook/pyrefly/issues/4042 with more examples

Reviewed By: maggiemoss

Differential Revision: D111155587
---
 .../tsp/tsp_interaction/get_type_queries.rs   | 189 ++++++++++++++++++
 1 file changed, 189 insertions(+)

diff --git a/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs b/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
index 0d7d268f38..e237312e45 100644
--- a/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
+++ b/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
@@ -787,6 +787,195 @@ fn test_get_computed_type_function_has_return_type() {
     tsp.shutdown();
 }
 
+// =======================================================================
+// getComputedType range routing: current behavior of identifier-name ranges,
+// which (apart from bare-name references) are NOT routed through the
+// declaration-preserving path.
+//
+// These document the stable baseline so a later change to the routing
+// predicate has something to diff against. The cases marked BUG return `null`
+// today even though a point query at the same position resolves correctly; the
+// following diff routes every identifier-name range through the binding path.
+// =======================================================================
+
+/// Like `get_computed_type_range_ok` but returns the raw result value, which
+/// may be JSON `null`. Used to document ranges that currently resolve to no
+/// type.
+fn get_computed_type_range_raw(
+    tsp: &mut TspInteraction,
+    file_uri: &str,
+    start_line: u32,
+    start_character: u32,
+    end_line: u32,
+    end_character: u32,
+    snapshot: i32,
+) -> serde_json::Value {
+    tsp.server.get_computed_type_range(
+        file_uri,
+        start_line,
+        start_character,
+        end_line,
+        end_character,
+        snapshot,
+    );
+    let resp = tsp.client.receive_response_skip_notifications();
+    assert!(
+        resp.error.is_none(),
+        "Expected success, got error: {:?}",
+        resp.error
+    );
+    resp.result.expect("Expected result field")
+}
+
+#[test]
+fn test_get_computed_type_class_def_name_range() {
+    // BUG: a class-def name range is routed to the trace path, which has no
+    // recorded type for a bare declaration name, so this returns null. A point
+    // query at the same position returns the class.
+    let (mut tsp, file_uri, snapshot) = setup_project("class Foo:\n    x: int = 0\n");
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 9, snapshot);
+    assert!(
+        result.is_null(),
+        "class-def name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_parameter_name_range() {
+    // BUG: a parameter name resolves through Key::Definition on the point path,
+    // but its range is routed to the trace path and returns null.
+    let (mut tsp, file_uri, snapshot) = setup_project("def f(x: int) -> int:\n    return x\n");
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
+    assert!(
+        result.is_null(),
+        "parameter name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_imported_name_range() {
+    // BUG: an imported name resolves through Key::Definition on the point path,
+    // but its range is routed to the trace path and returns null.
+    let (mut tsp, file_uri, snapshot) = setup_project("from os import getcwd\n");
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 15, 0, 21, snapshot);
+    assert!(
+        result.is_null(),
+        "imported name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_type_parameter_range() {
+    // BUG: a type-parameter name range is routed to the trace path and returns
+    // null.
+    let (mut tsp, file_uri, snapshot) = setup_project("def f[T](x: T) -> T:\n    return x\n");
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
+    assert!(
+        result.is_null(),
+        "type-parameter name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_imported_module_range() {
+    // BUG: an imported-module name range is routed to the trace path and
+    // returns null.
+    let (mut tsp, file_uri, snapshot) = setup_project("import os\n");
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 7, 0, 9, snapshot);
+    assert!(
+        result.is_null(),
+        "imported-module name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_exception_handler_range() {
+    // BUG: an exception-handler name range is routed to the trace path and
+    // returns null.
+    let code = "try:\n    pass\nexcept Exception as e:\n    pass\n";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 20, 2, 21, snapshot);
+    assert!(
+        result.is_null(),
+        "exception-handler name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_global_capture_range() {
+    // BUG: `global x` inside a function is a MutableCapture identifier; its
+    // range is routed to the trace path and returns null.
+    let code = "x = 1\ndef f():\n    global x\n";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 11, 2, 12, snapshot);
+    assert!(
+        result.is_null(),
+        "global-capture name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_match_capture_range() {
+    // BUG: a match-capture name range is routed to the trace path and returns
+    // null.
+    let code = "x = 1\nmatch x:\n    case y:\n        pass\n";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 9, 2, 10, snapshot);
+    assert!(
+        result.is_null(),
+        "match-capture name range currently returns null, got: {result}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_compound_expression_range_is_value() {
+    // A compound (non-identifier) range asks "what does this evaluate to"; it
+    // uses the trace path and returns the value type. This positive control
+    // locks in the negative case so a future "always preserve declaration"
+    // change cannot silently break it.
+    let code = "\
+def g(a: int, b: int) -> int:
+    return a + b
+
+g(1, 2)
+";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    // `a + b`
+    let binop = get_computed_type_range_ok(&mut tsp, &file_uri, 1, 11, 1, 16, snapshot);
+    assert_kind(&binop, TypeKind::Class);
+
+    // `g(1, 2)` — the call's return value, not the callee.
+    let call = get_computed_type_range_ok(&mut tsp, &file_uri, 3, 0, 3, 7, snapshot);
+    assert_kind(&call, TypeKind::Class);
+
+    tsp.shutdown();
+}
+
 #[test]
 fn test_get_computed_type_function_has_declaration() {
     // Verify that a def-function has a Regular declaration with name

From e4d8f088db6f33da4b69d217726ae634f8974479 Mon Sep 17 00:00:00 2001
From: Kyle Into <kylei@meta.com>
Date: Thu, 9 Jul 2026 10:20:58 -0700
Subject: [PATCH 2/2] getComputedType: route all declaration-name ranges
 through the binding path (#4091)

Summary:

fix https://github.com/facebook/pyrefly/issues/4042

by using the classifications in classify_surface

Reviewed By: stroxler

Differential Revision: D111155589
---
 pyrefly/lib/state/lsp.rs                      |  69 +++-
 .../tsp/tsp_interaction/get_type_queries.rs   | 304 ++++++++++++------
 2 files changed, 268 insertions(+), 105 deletions(-)

diff --git a/pyrefly/lib/state/lsp.rs b/pyrefly/lib/state/lsp.rs
index 4e9dc285ae..1d25f9a5ec 100644
--- a/pyrefly/lib/state/lsp.rs
+++ b/pyrefly/lib/state/lsp.rs
@@ -1161,7 +1161,33 @@ impl<'a> Transaction<'a> {
         else {
             return self.type_from_expression_at_impl(handle, position, false, for_display);
         };
-        match self.classify_surface(handle, &identifier, &context) {
+        let kind = self.classify_surface(handle, &identifier, &context);
+        self.type_from_resolution(
+            handle,
+            position,
+            &identifier,
+            &context,
+            kind,
+            for_display,
+            coerce_callees,
+        )
+    }
+
+    /// Compute the type for an already-classified identifier resolution. Split
+    /// out so callers that have already run `identifier_at`/`classify_surface`
+    /// (e.g. `get_computed_type_at_range`) can reuse that work instead of
+    /// re-resolving the same range.
+    fn type_from_resolution(
+        &self,
+        handle: &Handle,
+        position: TextSize,
+        identifier: &Identifier,
+        context: &IdentifierContext,
+        kind: ResolutionKind,
+        for_display: bool,
+        coerce_callees: bool,
+    ) -> Option<Type> {
+        match kind {
             ResolutionKind::Type(ty) => Some(ty),
             ResolutionKind::Key(key) => {
                 let bindings = self.get_bindings(handle)?;
@@ -1170,7 +1196,7 @@ impl<'a> Transaction<'a> {
                 }
                 let mut ty = self.get_type_for_surface(handle, &key, for_display)?;
                 // Only a plain expression reference coerces to its callee signature.
-                if coerce_callees && let IdentifierContext::Expr(_) = &context {
+                if coerce_callees && let IdentifierContext::Expr(_) = context {
                     let call_args_range = self.callee_at(handle, position).and_then(
                         |ExprCall {
                              func, arguments, ..
@@ -1242,18 +1268,37 @@ impl<'a> Transaction<'a> {
     ///
     /// TSP prefers raw bound types of identifiers since it re-resolves declarations.
     pub fn get_computed_type_at_range(&self, handle: &Handle, range: TextRange) -> Option<Type> {
-        // Bare names need declaration-preserving lookup to avoid coercing
-        // overloaded functions into synthesized callables.
-        if range.is_empty()
-            || self.get_ast(handle).is_some_and(|module| {
-                Ast::locate_node(&module, range.start())
-                    .into_iter()
-                    .any(|node| node.range() == range && matches!(node, AnyNodeRef::ExprName(_)))
-            })
-        {
+        // An empty range is a point query on the declaration-preserving path.
+        if range.is_empty() {
             return self.get_type_at_preserving_declaration(handle, range.start());
         }
-        self.get_type_trace(handle, range)
+        // A range that is exactly an identifier resolving through a binding asks
+        // "what is this declared as"; anything else asks "what does this range
+        // evaluate to". Classify once and reuse the resolution to compute the
+        // type, rather than re-resolving via `get_type_at_preserving_declaration`.
+        let Some(IdentifierWithContext {
+            identifier,
+            context,
+        }) = self.identifier_at(handle, range.start())
+        else {
+            return self.get_type_trace(handle, range);
+        };
+        let kind = self.classify_surface(handle, &identifier, &context);
+        if identifier.range == range
+            && matches!(kind, ResolutionKind::Key(_) | ResolutionKind::Type(_))
+        {
+            self.type_from_resolution(
+                handle,
+                range.start(),
+                &identifier,
+                &context,
+                kind,
+                false,
+                false,
+            )
+        } else {
+            self.get_type_trace(handle, range)
+        }
     }
 
     fn get_result_type_at_impl(
diff --git a/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs b/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
index e237312e45..ed8820bda7 100644
--- a/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
+++ b/pyrefly/lib/test/tsp/tsp_interaction/get_type_queries.rs
@@ -20,7 +20,26 @@ use crate::test::tsp::tsp_interaction::object_model::write_pyproject;
 fn setup_project(file_content: &str) -> (TspInteraction, String, i32) {
     let temp_dir = TempDir::new().unwrap();
     write_pyproject(temp_dir.path());
+    setup_project_in_dir(temp_dir, file_content)
+}
+
+fn setup_project_with_pyrefly_config(
+    file_content: &str,
+    pyrefly_config: &str,
+) -> (TspInteraction, String, i32) {
+    let temp_dir = TempDir::new().unwrap();
+    write_pyproject(temp_dir.path());
+
+    let pyproject = temp_dir.path().join("pyproject.toml");
+    let mut content = std::fs::read_to_string(&pyproject).unwrap();
+    content.push_str("\n[tool.pyrefly]\n");
+    content.push_str(pyrefly_config);
+    std::fs::write(pyproject, content).unwrap();
 
+    setup_project_in_dir(temp_dir, file_content)
+}
+
+fn setup_project_in_dir(temp_dir: TempDir, file_content: &str) -> (TspInteraction, String, i32) {
     let test_file = temp_dir.path().join("main.py");
     std::fs::write(&test_file, file_content).unwrap();
 
@@ -100,6 +119,34 @@ fn get_computed_type_range_ok(
     result
 }
 
+/// Like `get_computed_type_range_ok` but returns the raw result value, which may
+/// be JSON `null`. Used to document ranges that resolve to no type.
+fn get_computed_type_range_raw(
+    tsp: &mut TspInteraction,
+    file_uri: &str,
+    start_line: u32,
+    start_character: u32,
+    end_line: u32,
+    end_character: u32,
+    snapshot: i32,
+) -> serde_json::Value {
+    tsp.server.get_computed_type_range(
+        file_uri,
+        start_line,
+        start_character,
+        end_line,
+        end_character,
+        snapshot,
+    );
+    let resp = tsp.client.receive_response_skip_notifications();
+    assert!(
+        resp.error.is_none(),
+        "Expected success, got error: {:?}",
+        resp.error
+    );
+    resp.result.expect("Expected result field")
+}
+
 /// Helper to send a getExpectedType request and return a successful (non-null) result.
 fn get_expected_type_ok(
     tsp: &mut TspInteraction,
@@ -787,174 +834,245 @@ fn test_get_computed_type_function_has_return_type() {
     tsp.shutdown();
 }
 
-// =======================================================================
-// getComputedType range routing: current behavior of identifier-name ranges,
-// which (apart from bare-name references) are NOT routed through the
-// declaration-preserving path.
-//
-// These document the stable baseline so a later change to the routing
-// predicate has something to diff against. The cases marked BUG return `null`
-// today even though a point query at the same position resolves correctly; the
-// following diff routes every identifier-name range through the binding path.
-// =======================================================================
+#[test]
+fn test_get_computed_type_definition_site_uses_inferred_return_type() {
+    let code = "\
+def plain():
+    return True
 
-/// Like `get_computed_type_range_ok` but returns the raw result value, which
-/// may be JSON `null`. Used to document ranges that currently resolve to no
-/// type.
-fn get_computed_type_range_raw(
-    tsp: &mut TspInteraction,
-    file_uri: &str,
-    start_line: u32,
-    start_character: u32,
-    end_line: u32,
-    end_character: u32,
-    snapshot: i32,
-) -> serde_json::Value {
-    tsp.server.get_computed_type_range(
-        file_uri,
-        start_line,
-        start_character,
-        end_line,
-        end_character,
-        snapshot,
-    );
-    let resp = tsp.client.receive_response_skip_notifications();
-    assert!(
-        resp.error.is_none(),
-        "Expected success, got error: {:?}",
-        resp.error
+class C:
+    def method(self):
+        return 1
+
+    @property
+    def ok(self):
+        return True
+
+plain
+";
+    let (mut tsp, file_uri, snapshot) = setup_project_with_pyrefly_config(
+        code,
+        "untyped-def-behavior = \"check-and-infer-return-type\"\n",
     );
-    resp.result.expect("Expected result field")
+
+    for (start_line, start_character, end_line, end_character, label) in [
+        (0, 4, 0, 9, "plain function definition"),
+        (4, 8, 4, 14, "method definition"),
+        (8, 8, 8, 10, "property getter definition"),
+        (11, 0, 11, 5, "plain function reference"),
+    ] {
+        let result = get_computed_type_range_ok(
+            &mut tsp,
+            &file_uri,
+            start_line,
+            start_character,
+            end_line,
+            end_character,
+            snapshot,
+        );
+        assert_kind(&result, TypeKind::Function);
+
+        let return_type = result
+            .get("returnType")
+            .unwrap_or_else(|| panic!("Expected returnType for {label}: {result}"));
+        assert_kind(return_type, TypeKind::Class);
+    }
+
+    tsp.shutdown();
 }
 
+// =======================================================================
+// getComputedType range routing: an identifier-name range resolves through
+// the declaration-preserving binding path, matching a point query at the
+// same position, rather than falling through to the (empty) expression trace.
+// =======================================================================
+
 #[test]
 fn test_get_computed_type_class_def_name_range() {
-    // BUG: a class-def name range is routed to the trace path, which has no
-    // recorded type for a bare declaration name, so this returns null. A point
-    // query at the same position returns the class.
+    // A class-def name is the same category of identifier as a function-def
+    // name; its range resolves to the class through the binding path.
     let (mut tsp, file_uri, snapshot) = setup_project("class Foo:\n    x: int = 0\n");
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 9, snapshot);
-    assert!(
-        result.is_null(),
-        "class-def name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 0, 6, 0, 9, snapshot);
+    assert_kind(&result, TypeKind::Class);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_parameter_name_range() {
-    // BUG: a parameter name resolves through Key::Definition on the point path,
-    // but its range is routed to the trace path and returns null.
     let (mut tsp, file_uri, snapshot) = setup_project("def f(x: int) -> int:\n    return x\n");
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
-    assert!(
-        result.is_null(),
-        "parameter name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
+    assert_kind(&result, TypeKind::Class);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_imported_name_range() {
-    // BUG: an imported name resolves through Key::Definition on the point path,
-    // but its range is routed to the trace path and returns null.
     let (mut tsp, file_uri, snapshot) = setup_project("from os import getcwd\n");
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 15, 0, 21, snapshot);
-    assert!(
-        result.is_null(),
-        "imported name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 0, 15, 0, 21, snapshot);
+    assert_kind(&result, TypeKind::Function);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_type_parameter_range() {
-    // BUG: a type-parameter name range is routed to the trace path and returns
-    // null.
     let (mut tsp, file_uri, snapshot) = setup_project("def f[T](x: T) -> T:\n    return x\n");
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
-    assert!(
-        result.is_null(),
-        "type-parameter name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 0, 6, 0, 7, snapshot);
+    assert_kind(&result, TypeKind::Typevar);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_imported_module_range() {
-    // BUG: an imported-module name range is routed to the trace path and
-    // returns null.
     let (mut tsp, file_uri, snapshot) = setup_project("import os\n");
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 0, 7, 0, 9, snapshot);
-    assert!(
-        result.is_null(),
-        "imported-module name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 0, 7, 0, 9, snapshot);
+    assert_kind(&result, TypeKind::Module);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_exception_handler_range() {
-    // BUG: an exception-handler name range is routed to the trace path and
-    // returns null.
     let code = "try:\n    pass\nexcept Exception as e:\n    pass\n";
     let (mut tsp, file_uri, snapshot) = setup_project(code);
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 20, 2, 21, snapshot);
-    assert!(
-        result.is_null(),
-        "exception-handler name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 2, 20, 2, 21, snapshot);
+    assert_kind(&result, TypeKind::Class);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_global_capture_range() {
-    // BUG: `global x` inside a function is a MutableCapture identifier; its
-    // range is routed to the trace path and returns null.
+    // `global x` inside a function is a MutableCapture identifier.
     let code = "x = 1\ndef f():\n    global x\n";
     let (mut tsp, file_uri, snapshot) = setup_project(code);
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 11, 2, 12, snapshot);
-    assert!(
-        result.is_null(),
-        "global-capture name range currently returns null, got: {result}"
-    );
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 2, 11, 2, 12, snapshot);
+    assert_kind(&result, TypeKind::Class);
 
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_match_capture_range() {
-    // BUG: a match-capture name range is routed to the trace path and returns
-    // null.
     let code = "x = 1\nmatch x:\n    case y:\n        pass\n";
     let (mut tsp, file_uri, snapshot) = setup_project(code);
 
-    let result = get_computed_type_range_raw(&mut tsp, &file_uri, 2, 9, 2, 10, snapshot);
+    let result = get_computed_type_range_ok(&mut tsp, &file_uri, 2, 9, 2, 10, snapshot);
+    assert_kind(&result, TypeKind::Class);
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_keyword_argument_label_range() {
+    // A keyword-argument label maps to the matched parameter's declaration, so
+    // its range resolves to the parameter's type through the binding path. A
+    // label that matches no parameter has no type of its own and falls back to
+    // the (empty) trace path.
+    let code = "def f(x: int) -> int:\n    return x\n\nf(x=1)\nf(y=1)\n";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    // `x` label in `f(x=1)` resolves to parameter `x`'s type.
+    let matched = get_computed_type_range_ok(&mut tsp, &file_uri, 3, 2, 3, 3, snapshot);
+    assert_kind(&matched, TypeKind::Class);
+
+    // `y` label in `f(y=1)` matches no parameter, so it falls through to the
+    // trace path, which has no recorded type for the label.
+    let unmatched = get_computed_type_range_raw(&mut tsp, &file_uri, 4, 2, 4, 3, snapshot);
     assert!(
-        result.is_null(),
-        "match-capture name range currently returns null, got: {result}"
+        unmatched.is_null(),
+        "unmatched keyword label should fall back to the trace path (null), got: {unmatched}"
+    );
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_overload_def_and_call_range() {
+    // Overloaded defs already route through the declaration-preserving path
+    // (FunctionDef context for the def, Expr context for the reference), so
+    // both sites resolve to the overloaded type rather than a synthesized
+    // callable for the selected overload.
+    let code = "\
+from typing import overload
+
+@overload
+def f(x: int) -> int: ...
+@overload
+def f(x: str) -> str: ...
+def f(x):
+    return x
+
+f(1)
+";
+    let (mut tsp, file_uri, snapshot) = setup_project(code);
+
+    // Implementation def-site name range.
+    let def_site = get_computed_type_range_ok(&mut tsp, &file_uri, 6, 4, 6, 5, snapshot);
+    assert_kind(&def_site, TypeKind::Overloaded);
+
+    // Call-site name range.
+    let call_site = get_computed_type_range_ok(&mut tsp, &file_uri, 9, 0, 9, 1, snapshot);
+    assert_kind(&call_site, TypeKind::Overloaded);
+
+    tsp.shutdown();
+}
+
+#[test]
+fn test_get_computed_type_classmethod_staticmethod_inferred_return() {
+    let code = "\
+class C:
+    @classmethod
+    def cm(cls):
+        return 1
+
+    @staticmethod
+    def sm():
+        return True
+";
+    let (mut tsp, file_uri, snapshot) = setup_project_with_pyrefly_config(
+        code,
+        "untyped-def-behavior = \"check-and-infer-return-type\"\n",
     );
 
+    for (start_line, start_character, end_line, end_character, label) in [
+        (2, 8, 2, 10, "classmethod definition"),
+        (6, 8, 6, 10, "staticmethod definition"),
+    ] {
+        let result = get_computed_type_range_ok(
+            &mut tsp,
+            &file_uri,
+            start_line,
+            start_character,
+            end_line,
+            end_character,
+            snapshot,
+        );
+        assert_kind(&result, TypeKind::Function);
+
+        let return_type = result
+            .get("returnType")
+            .unwrap_or_else(|| panic!("Expected returnType for {label}: {result}"));
+        assert_kind(return_type, TypeKind::Class);
+    }
+
     tsp.shutdown();
 }
 
 #[test]
 fn test_get_computed_type_compound_expression_range_is_value() {
-    // A compound (non-identifier) range asks "what does this evaluate to"; it
-    // uses the trace path and returns the value type. This positive control
+    // A compound (non-identifier) range asks "what does this evaluate to";
+    // it must keep using the trace path and return the value type. This
     // locks in the negative case so a future "always preserve declaration"
     // change cannot silently break it.
     let code = "\