From a63031089a7d24b0901c38d750b196e53320dc70 Mon Sep 17 00:00:00 2001 From: Edmond Chui <1967998+EdmondChuiHW@users.noreply.github.com> Date: Thu, 14 Mar 2024 16:21:52 +0000 Subject: [PATCH 1/2] rm interface from RNPerfMetrics --- front_end/core/host/RNPerfMetrics.ts | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/front_end/core/host/RNPerfMetrics.ts b/front_end/core/host/RNPerfMetrics.ts index 104997934ab..f2f60f57bf1 100644 --- a/front_end/core/host/RNPerfMetrics.ts +++ b/front_end/core/host/RNPerfMetrics.ts @@ -5,26 +5,20 @@ export type RNReliabilityEventListener = (event: ReactNativeChromeDevToolsEvent) => void; -type UnsunscribeFn = () => void; -export type RNPerfMetrics = { - addEventListener: (listener: RNReliabilityEventListener) => UnsunscribeFn, - removeAllEventListeners: () => void, - sendEvent: (event: ReactNativeChromeDevToolsEvent) => void, -}; - let instance: RNPerfMetrics|null = null; export function getInstance(): RNPerfMetrics { if (instance === null) { - instance = new RNPerfMetricsImpl(); + instance = new RNPerfMetrics(); } return instance; } -class RNPerfMetricsImpl implements RNPerfMetrics { +type UnsunscribeFn = () => void; +class RNPerfMetrics { #listeners: Set = new Set(); - addEventListener(listener: RNReliabilityEventListener): () => void { + addEventListener(listener: RNReliabilityEventListener): UnsunscribeFn { this.#listeners.add(listener); const unsubscribe = (): void => { From 635a2bb06defb8f0152d319ee0e71a54e3e04e65 Mon Sep 17 00:00:00 2001 From: Edmond Chui <1967998+EdmondChuiHW@users.noreply.github.com> Date: Fri, 22 Mar 2024 15:55:39 +0000 Subject: [PATCH 2/2] Fix typo in RNPerfMetrics.ts --- front_end/core/host/RNPerfMetrics.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/front_end/core/host/RNPerfMetrics.ts b/front_end/core/host/RNPerfMetrics.ts index f2f60f57bf1..cc78ad02400 100644 --- a/front_end/core/host/RNPerfMetrics.ts +++ b/front_end/core/host/RNPerfMetrics.ts @@ -14,11 +14,11 @@ export function getInstance(): RNPerfMetrics { return instance; } -type UnsunscribeFn = () => void; +type UnsubscribeFn = () => void; class RNPerfMetrics { #listeners: Set = new Set(); - addEventListener(listener: RNReliabilityEventListener): UnsunscribeFn { + addEventListener(listener: RNReliabilityEventListener): UnsubscribeFn { this.#listeners.add(listener); const unsubscribe = (): void => {