Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add createJSModules for backward compatibility #354
#345 removed the method completely. This PR is to provide backward compatibility for older react native versions.
I'm not too bothered which approach we use, remove it or keep for compatibility. Could we have a release soon to allow us to use React Native 0.47?
@punarinta You will not get a compile error in 0.47 if the method isn't annotated with
The annotation causes the compile error, it is used as a compile time validation. The compiler will check if the interface has a method of the same name.
This is the same approach as Sentry getsentry/sentry-react-native#172
- explanation: https://stackoverflow.com/questions/45659897/react-native-unable-to-build-project/45660080#45660080 - module change: facebook/react-native-fbsdk@065507a - command to fix: facebook/react-native-fbsdk#354 (comment)