Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Docs Drive #1579

Open
rachelnabors opened this issue Feb 5, 2020 · 91 comments
Open

Component Docs Drive #1579

rachelnabors opened this issue Feb 5, 2020 · 91 comments

Comments

@rachelnabors
Copy link
Contributor

@rachelnabors rachelnabors commented Feb 5, 2020

We have a lot of component and API docs that need updating! The good news is that updating these docs can be a fun way to become more familiar with React Native’s core code while contributing to docs that help thousands of learners around the world! If this looks intimidating, we have you covered! There’s a handy guide below that should help you out :)

What needs updating?

  • Update the API to reflect the props and methods reflected in core
  • Ensure example code is 1) in a Snack player and 2) uses function components and Hooks:
    • Add example code if it is missing
    • Update example code to use function components and React Hooks
    • Put example code in an embedded Snack player

How to contribute?

  1. First, select a component or API from the table below.
  2. Choose a single update to make:
    1. Update the API
    2. Add missing example code
    3. Convert existing example code to use function components and React Hooks
    4. Embed any existing example code in a Snack player
  3. Comment below on what component/API you want to take on and which fix; I'll update the matrix with your name
  4. Submit your PR tagged with this issue

When your PR is merged, we’ll convert your name into a checkmark, indicating completion!

Update the API to reflect the props and methods reflected in core

This part requires a little investigating! Check react-native/Libraries/YourComponent and** **react-native/Libraries/Components/YourComponent for your component or API’s list of props. Sometimes they can be hidden, like the LayoutProps API is in react-native/Libraries/StyleSheet/StyleSheetTypes.js.

Pro tip: If you get stuck, search for “YourComponent.js” or search the “YourComponent” with a prop or method already listed.

Add missing example code

If there is no example code, add a new example using function components and Hooks. Embed your code with a Snack player like so:

```SnackPlayer name=Component/API%20Example

// Example code goes here

``` 

Convert existing example code to use function components and Hooks

If there’s a class component example already, use this handy guide on converting class components to function components and Hooks to make a function component example. Then use the following code snippet to keep both function and class component examples (please remove the first and final ```—markdown formating trouble!):

```
<div class="toggler">
  <ul role="tablist" class="toggle-syntax">
    <li id="functional" class="button-functional" aria-selected="false" role="tab" tabindex="0" aria-controls="functionaltab" onclick="displayTabs('syntax', 'functional')">
      Function Component Example
    </li>
    <li id="classical" class="button-classical" aria-selected="false" role="tab" tabindex="0" aria-controls="classicaltab" onclick="displayTabs('syntax', 'classical')">
      Class Component Example
    </li>
  </ul>
</div>

<block class="functional syntax" />

```SnackPlayer name=Component/API%20Function%20Component%20Example

// Function Component Example goes here

```

<block class="classical syntax" />

```SnackPlayer name=Component/API%20Class%20Component%20Example

// Class Example goes here

```

<block class="endBlock syntax" />
```

If there isn’t a class component example or there was already a function component example, just use the following code to embed just a function component example.

Embed any example code with a Snack player

```SnackPlayer name=Component/API%20Example

// Example code goes here

```

Submit your PR!

Follow the repo's setup instructions here.

Remember your doc changes will be under facebook.github.io/react-native/docs/**next/**yourcomponent, not facebook.github.io/react-native/docs/yourcomponent

  1. Work on master docs (docs/.md), not versioned ones (website/versioned_docs/version-0./*.md)
  2. Tag your PR with this issue #1579 so it gets properly recognized

Code Tips

  • Run any code examples through (https://prettier.io/)[Prettier] to format it consistently
  • Extract styles to StyleSheet outside of component and at bottom of sample
  • Use arrow functions instead of anonymous functions
  • Do not leave unused imports
  • Sort imports alphabetically
  • Remember to use semicolons (especially after exports)
  • Name your Snack "<Component/API>%20Example"
  • If the API or component is platform specific, specify which platforms for the Snack player to show like so: ```SnackPlayer name=AndroidOnlyAPI&supportedPlatforms=web,android
  • If the API or component has platform specific parts, use supportedPlatforms

Components and APIs update progress

API up to date? Has example? Example uses Snack? Example uses function components and Hooks?
Components
ActivityIndicator ✔️ ✔️ ✔️ ✔️ @ronnyiscoding #1590
Button ✔️ ✔️ ✔️ ✔️ @dsznajde #1592
DrawerLayoutAndroid
✔️
FlatList ✔️ ✔️ ✔️ @lfoliveir4
Image
✔️ ✔️ ✔️ @amandeepmittal #1582
ImageBackground ✔️ ✔️ @alvessteve @alvessteve
InputAccessoryView ✔️ ✔️ ✔️
KeyboardAvoidingView ✔️ ✔️ ✔️ @nnajiabraham ✔️ @nnajiabraham
Modal ✔️ @Darking360 #1605 ✔️ ✔️ @Darking360 #1605 ✔️ @Darking360 #1605
Picker ✔️ ✔️ ✔️ @kaioduarte #1595 ✔️ @kaioduarte #1595
RefreshControl ✔️ ✔️ ✔️
SafeAreaView ✔️ ✔️ ✔️
ScrollView ✔️ ✔️ ✔️
SectionList @codecog @codecog @codecog @codecog
StatusBar ✔️ ✔️ @espipj #1624 ✔️ @espipj #1624 ✔️
Switch ✔️ ✔️ @kaioduarte #1594 ✔️ @kaioduarte #1594 ✔️ @kaioduarte #1594
TabBarIOS
TabBarIOS.item
Text ✔️ ✔️ @tsawan @tsawan
TextInput @espipj/@Naturalclar #1584 ✔️ ✔️ ✔️
TouchableHighlight ✔️ @dsznajder #1591 ✔️ ✔️ @dsznajder #1591 ✔️
TouchableNativeFeedback
✔️
✔️
TouchableOpacity ✔️ ✔️ :heavy_check_mark ✔️ @kaioduarte #1596 ✔️
TouchableWithoutFeedback ✔️ ✔️
✔️
View ✔️ ✔️ ✔️ @amandeepmittal #1582 ✔️ @amandeepmittal #1582
VirtualizedList @ronnyiscoding @ronnyiscoding @nnajiabraham @nnajiabraham
APIs
AccessibilityInfo ✔️ ✔️ @mdabrowka @mdabrowka
ActionSheetIOS ✔️
Alert ✔️ ✔️ ✔️ @DaniAkash #1597 ✔️ @DaniAkash #1597
Animated @jeremy-deutsch & @DaniAkash @jeremy-deutsch & @DaniAkash @jeremy-deutsch & @DaniAkash @jeremy-deutsch & @DaniAkash
AppRegistry
AppState
✔️
@tsawan
BackHandler ✔️ ✔️
Dimensions ✔️ @DaniAkash @DaniAkash @DaniAkash
Easing ✔️
Image Style Props @ronnyiscoding @ronnyiscoding @ronnyiscoding @ronnyiscoding
InteractionManager ✔️ ✔️
Keyboard @ahmdtalaat ✔️ @ahmdtalaat @ahmdtalaat
Layout Props @miganga @miganga @miganga @miganga
LayoutAnimation ✔️ ✔️ @DaniAkash @DaniAkash
Linking @lcelso ✔️ @lcelso @lcelso
PanResponder
✔️
✔️
PermissionsAndroid ✔️ ✔️
✔️
PixelRatio ✔️ ✔️
✔️
Settings ✔️
Shadow Props ✔️
Share ✔️ @amandeepmittal @amandeepmittal @amandeepmittal
StyleSheet @lcelso ✔️ @lcelso ✔️
Systrace ✔️
Text Style Props ✔️
ToastAndroid ✔️ ✔️ ✔️ @espipj #1614 ✔️
Transforms ✔️ @DaniAkash @DaniAkash @DaniAkash
Vibration ✔️ ✔️
✔️
View Style Props ✔️ @mitulsavani #1612 ✔️ @mitulsavani #1612 ✔️ @mitulsavani #1612 ✔️ @mitulsavani #1612
@rachelnabors rachelnabors pinned this issue Feb 5, 2020
@amandeepmittal

This comment has been minimized.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 5, 2020

Hi @rachelnabors,

One question, sorry for my naivety, if I am converting a class example into functional example (just converting the snack from class to function) do I keep both the snacks? Also, do I explicitly mention <block class="functional syntax" /> in each snack?

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

(I)f I am converting a class example into functional example (just converting the snack from class to function) do I keep both the snacks?

Yes!

Also, do I explicitly mention <block class="functional syntax" /> in each snack?

It's probably best for you to copy the code block under "Convert existing example code to use function components and Hooks," then replace // Class Example goes here with the former, class-based example. Then replace // Function Example goes here with a function/Hooks example.

Please correct me if I misunderstood your question!

@amandeepmittal

This comment has been minimized.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 5, 2020

Thank you so much. I understood the point of the whole code block. I should have read the class name on the top that says toggler. 😅 It clearly says what it does.

I have updated my PR according to the code block.

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

@amandeepmittal Did you follow steps 3 and 4, too? ;)

@DaniAkash

This comment has been minimized.

Copy link
Contributor

@DaniAkash DaniAkash commented Feb 5, 2020

@rachelnabors Just created a PR for the DatePickerIOS 🗓. I basically rewrote the existing class component into a functional component with hooks. But It clearly has a lot of props, does the Snack have to cover all the props or basic functionality is enough?

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

You know, DatePickerIOS is actually in the process of being deprecated! It sneaked into the table somehow (tsk tsk!). I just removed it. I'm accepting your PR regardless, but go pour your energy into another component who will be sticking around!

@amandeepmittal

This comment was marked as outdated.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 5, 2020

@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?

@DaniAkash

This comment has been minimized.

Copy link
Contributor

@DaniAkash DaniAkash commented Feb 5, 2020

You know, DatePickerIOS is actually in the process of being deprecated! It sneaked into the table somehow (tsk tsk!). I just removed it. I'm accepting your PR regardless, but go pour your energy into another component who will be sticking around!

It did well for a test subject 😜 will pick up something more vital next...

@rachelnabors

This comment was marked as outdated.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?

@amandeepmittal, are you not able to edit the original post? I tried to put checkboxes in there but couldn't make them work inside tables! Thanks for bearing with me!

@amandeepmittal

This comment was marked as outdated.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 5, 2020

@rachelnabors do you have copy-paste version of the matrix table? Also should quote the matrix here or in the PR?

@amandeepmittal, are you not able to edit the original post? I tried to put checkboxes in there but couldn't make them work inside tables! Thanks for bearing with me!

Nope. Can't edit your original post here. No worries. Thank you getting back to me so quickly.

@rachelnabors

This comment was marked as outdated.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

Hmm. Gonna have to think of a way for people to claim each task..

@amandeepmittal

This comment was marked as outdated.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 5, 2020

Hmm. Gonna have to think of a way for people to claim each task..

Can we do this in a gist and link it here? Just a suggestion 🤷‍♂️

@rachelnabors

This comment was marked as outdated.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

I added checkboxes :) Just tick one for each task you claim. I'll update them to bold checks when the PRs are merged!

@jeremy-deutsch

This comment has been minimized.

Copy link
Contributor

@jeremy-deutsch jeremy-deutsch commented Feb 5, 2020

I’d like to claim the Animated API up-to-date; how do I check off one of those boxes? Maybe it just doesn’t work since I’m on mobile

@DaniAkash

This comment has been minimized.

Copy link
Contributor

@DaniAkash DaniAkash commented Feb 5, 2020

I’d like to claim the Animated API up-to-date; how do I check off one of those boxes? Maybe it just doesn’t work since I’m on mobile

I'd like to pick this one up too. Given the size of the API, can we share this between us?

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

Why don't you both split the load? I'll put your names down for the different tasks (since the checkboxes aren't working!). How do you want to split it?

@mitulsavani

This comment has been minimized.

Copy link
Contributor

@mitulsavani mitulsavani commented Feb 5, 2020

Hi there, I would like to claim for View Style Prop

@jeremy-deutsch

This comment has been minimized.

Copy link
Contributor

@jeremy-deutsch jeremy-deutsch commented Feb 5, 2020

@rachelnabors I could document the API for Animated.Value/Animated.ValueXY, and leave the rest of Animated to @DaniAkash

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 5, 2020

@mitulsavani You got it! Don't forget to reference this issue in your PR!

@codecog

This comment has been minimized.

Copy link

@codecog codecog commented Feb 5, 2020

@rachelnabors feel free to assign <SectionList /> to me!

@alvessteve

This comment has been minimized.

Copy link

@alvessteve alvessteve commented Feb 5, 2020

@rachelnabors I'll take the ImageBackground :)

@dsznajder

This comment has been minimized.

Copy link
Contributor

@dsznajder dsznajder commented Feb 5, 2020

@rachelnabors I'll take TouchableHighlight :)

@ronnyiscoding

This comment has been minimized.

Copy link
Contributor

@ronnyiscoding ronnyiscoding commented Feb 5, 2020

@rachelnabors here goes my first PR, #1590

@Darking360

This comment has been minimized.

Copy link

@Darking360 Darking360 commented Feb 5, 2020

@rachelnabors Can I take Modal? Thank you ❤️

@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 11, 2020

@Simek @rachelnabors
I understand your point of view and agree that we should have a scenario in which editing the javascript files is a little easier.

I was analyzing some PRs here and I miss some patterns, like 2 spaces, single quotes, among other points, in which I believe we can define this here as a team, what do you think?

Another point is, I am Brazilian and here we have only 5% of the people who speak the English language link. Reflecting on this, do you think we can have some language context? Mainly in the context for examples.

Another point that would be interesting for a better flow, would be some channel in Slack for better communication, what do you think?

On the points that you raised from the interruption, I really totally agree.

@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 11, 2020

Hi guys, can someone review this for me?

@Simek @rachelnabors
#1626

@tsawan

This comment has been minimized.

Copy link

@tsawan tsawan commented Feb 12, 2020

@rachelnabors I can also change "Image" and "AppState" examples to use functional components and hooks.

@luism3861

This comment has been minimized.

Copy link
Contributor

@luism3861 luism3861 commented Feb 12, 2020

@DaniAkash

This comment has been minimized.

Copy link
Contributor

@DaniAkash DaniAkash commented Feb 13, 2020

I'm struggling to get the RNTester app running in my machine. Anyone else facing issue with running RNTester?

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 15, 2020

Hi everyone, sorry for the absence. Got sick again!

Matrix is updated!

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 15, 2020

@lcelso We have a discord we could use to coordinate, but then we'd have to track in two locations, which historically can be even more confusing! If you want to team up with someone, I suggest you reach out to them personally and choose the format of your choice to coordinate :) Could you expand on "do you think we can have some language context? Mainly in the context for examples."?

@mitulsavani

This comment has been minimized.

Copy link
Contributor

@mitulsavani mitulsavani commented Feb 17, 2020

Hi @rachelnabors, I see that you recently updated the metrics and tick marked View Style Props and referenced #1614 on it. I am not sure if that was a typo if so then, my PR is #1612 FYI.

I wonder if there is anything else that I need to finish for View Style Props? If not then, I can start working on other pending work

@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 18, 2020

@rachelnabors Hello, I believe that a faster communication channel could speed up some points, such as clearing doubts, which we can remove / discontinue.

Especially between some points of decisions and this done we can make official here.

About languages, I was seeing react.org and this is already done there.

This is a point if we have a group on Slack or anywhere else that we will have a more fluid communication.

We can discuss tools or other things like that and I try to have a better agility to give things a better flow.

What do you say?

@amandeepmittal

This comment has been minimized.

Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 18, 2020

Hi @rachelnabors, I will update the Share API by adding functional and hooks example since it already has the class component example.

@Simek

This comment has been minimized.

Copy link
Contributor

@Simek Simek commented Feb 18, 2020

@rachelnabors Could you asses the idea proposed in #1579 (comment)?

@DaniAkash

This comment has been minimized.

Copy link
Contributor

@DaniAkash DaniAkash commented Feb 18, 2020

@lcelso I agree that developing examples could be a bit more difficult due to fact that code is embedded in Markdown. Having examples in separate JS files would be nice (for example we can setup linter than etc.) but changing project architecture and converting all docs could be a challenging and daunting process. I don't even know if it's possible within Docusaurus. Also switch to Gatsby is not likely since Docusaurus is a Facebook product and Gatsby is not (also purpose of those platforms is bit different). Many code editors/IDEs this days can highlight JS code properly inside other type files (screenshot). Running website on localhost and developing with live preview also helps a lot.

But back to main topic. @rachelnabors Since Clipboard API is being deprecated (#1608) I would like to propose removal of this API from the TODO list (I would like to apologize authors of #1599 and #1604 for that).

It's also a good opportunity to start conversation about removing ALL existing examples from the deprecated components (leaving short description and reference only) before next major release. This whole idea started here #1583 (comment) but I think that this thread is a better place for this conversation.

Few pages in the master docs right now follow this pattern (ImageEditor, PickerIOS, Slider) but most of deprecated pages include examples. In my opinion removing those examples can force (mainy new) users to follow deprecation notice and use the proper maintained and up to date package which always contains an example or a few of them in the README. There are more benefits to users regarding to compatibility, or better support with issues for those packages but I would like also to hear you opinion about this idea.

While it is a good idea to remove the options from the sidebar, I still feel removing the examples would be bit harsh for people who are already heavily using these components...

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 18, 2020

@Simek I can confirm that deprecated components will be removed from the sidebar but their legacy pages will live on quietly—there is no harm in finishing up the examples! I hope this settles things.

@amandeepmittal you're on Share, thanks!

@lcelso Will need to hear more support from other people for your idea—worry another communication channel now would slow down and split communications rather than keeping us moving in one direction with one source of truth—this location. Feel free to coordinate privately on individual collaborations, naturally.

@mitulsavani I'll correct the issue post haste.

Next up: I'll be removing pieces of the matrix that have been completed to make it easier to see what's left to do. Thanks, everyone, for your hard work so far!

@Simek

This comment has been minimized.

Copy link
Contributor

@Simek Simek commented Feb 19, 2020

@rachelnabors Are there any changes planned for the Components and APIs page? Would you like to mark in some way or even remove deprecated pages listed in there?

@rachelnabors

This comment has been minimized.

Copy link
Contributor Author

@rachelnabors rachelnabors commented Feb 19, 2020

@Simek Smart thinking! And to think I've been looking at this page the whole week without realizing it! What a cold! Good thing you're on the ball!

We should remove the deprecated components and APIs from the page as we are removing them from the sidebar as well. Would you like to handle that one?

@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 19, 2020

@rachelnabors @Simek

I created a channel for quick communication and central points of doubts here.

link to slack

However I agree that here we must have the data and everything that was talked about there registered here.

What do you say?

Because I think so, I am feeling our agility / decision making is very slow.

There are points of doubt about how we should do it and even points of discussion with better fluidity.

We currently have many PRs stopped a lot of them for many days. Among other points where we can try to start reviewing this.

@Simek

This comment has been minimized.

Copy link
Contributor

@Simek Simek commented Feb 20, 2020

@rachelnabors I think that "API" link in top bar which leads to ActivityIndicator page instead of Components and APIs page in next docs do not help either 😉

Back to the deprecation discussion - I would like to help with those changes but I'm still not 100% sure how to perform them.

In my opinion, in some point in time 0.61 docs should be regenerated to include all the work from this issue and more changes that landed on the next docs during last months (I assume this should happen before or on 0.62 release?).

Merging sidebar and Components and APIs deprecation cleanup PRs before refreshing 0.61 will cause a loss of some improvements (mainly deprecation indicators and notes because they are currently only on the next docs and are targeted to be deleted before/on 0.62 release). That is also the reason why I was talking about generating 0.62 docs when you asked about sidebar changes in earlier discussion.

@Simek

This comment has been minimized.

Copy link
Contributor

@Simek Simek commented Feb 20, 2020

@lcelso I think that Slack/Teams/Discord channel will help with communication and can streamline PR processes but you should remember that this is still a Facebook repo which is not officially maintained by the community.

In my opinion creating this kind of communication platform should be approved and managed by FB employees (maintainers). If your idea got a green light of course I will join along.

@mitulsavani

This comment has been minimized.

Copy link
Contributor

@mitulsavani mitulsavani commented Feb 20, 2020

@lcelso I think that Slack/Teams/Discord channel will help with communication and can streamline PR processes but you should remember that this is still a Facebook repo which is not officially maintained by the community.

In my opinion creating this kind of communication platform should be approved and managed by FB employees (maintainers). If your idea got a green light of course I will join along.

I definitely agree with @Simek opinion, @lcelso I recommend you to open an issue on core react native repo to discuss further about it.

@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 20, 2020

Hello guys,

I agree for this I opened the discussion here with @rachelnabors and she gave me this answer. If I got it wrong I'm sorry.

@lcelso Will need to hear more support from other people for your idea—worry another communication channel now would slow down and split communications rather than keeping us moving in one direction with one source of truth—this location. Feel free to coordinate privately on individual collaborations, naturally.

And if this suggestion is a bad point I would like to understand how we can resolve the points below:

  • Long standing PRs
  • Doubts of those who want to help and have a quick flow of responses
  • Discussions on topics that we can make obsolete or not
  • Define a development standardization (For example use 'or', etc.)
@lcelso

This comment has been minimized.

Copy link
Contributor

@lcelso lcelso commented Feb 20, 2020

@rachelnabors Acho que o link "API" na barra superior que leva à ActivityIndicatorpágina em vez da Components and APIspágina nos nextdocumentos também não ajuda😉

De volta à discussão sobre descontinuação - eu gostaria de ajudar com essas alterações, mas ainda não tenho 100% de certeza de como executá-las.

Na minha opinião, em algum momento os 0.61documentos devem ser regenerados para incluir todo o trabalho desse problema e mais alterações que chegaram aos nextdocumentos nos últimos meses (presumo que isso deva acontecer antes ou no 0.62lançamento?).

A mesclagem de Components and APIsPRs de limpeza da barra lateral e de descontinuação antes da atualização 0.61causará uma perda de algumas melhorias (principalmente indicadores e notas de descontinuação, porque eles estão atualmente apenas nos nextdocumentos e devem ser excluídos antes / no 0.62lançamento). Essa também é a razão pela qual eu estava falando sobre a geração de 0.62documentos quando você perguntou sobre alterações na barra lateral em discussões anteriores.

I would like to help with this too

@cosio55

This comment has been minimized.

Copy link

@cosio55 cosio55 commented Feb 20, 2020

Hi @rachelnabors I was looking at the missing components and I saw that TabBarIOS & TabBarIOS.item were deprecated on RN 0.5959 here's the CHANGELOG they don't appear on the docs for version 0.59 but they re appeared on version 60 and 61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.