Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePickerIOS - Added Snack Examples 馃嵖 #1583

Merged
merged 3 commits into from Feb 7, 2020

Conversation

@DaniAkash
Copy link
Contributor

DaniAkash commented Feb 5, 2020

Belongs to #1579

Created a nice little snack for people to view DatePickerIOS in action using both Function & Class Component examples.

@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 5, 2020

Deploy preview for react-native ready!

Built with commit f882480

https://deploy-preview-1583--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

rachelnabors left a comment

Thanks for committing this!

Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code
docs/datepickerios.md Outdated Show resolved Hide resolved
docs/datepickerios.md Outdated Show resolved Hide resolved
@Simek

This comment has been minimized.

Copy link
Contributor

Simek commented Feb 6, 2020

I'm not sure if adding an example for the the deprecated component is a good idea.

They will be sooner or later completely removed form the codebase and not providing examples for them could be a good way to discourage usage of those components.

@DaniAkash

This comment has been minimized.

Copy link
Contributor Author

DaniAkash commented Feb 6, 2020

I'm not sure if adding an example for the the deprecated component is a good idea.

They will be sooner or later completely removed form the codebase and not providing examples for them could be a good way to discourage usage of those components.

@Simek I'll leave the decision to the maintainers 馃憤

@Simek

This comment has been minimized.

Copy link
Contributor

Simek commented Feb 7, 2020

It seems that Rachel got similar concerns to my: #1579 (comment)

@rachelnabors Also after thinking about this a bit more I would like to start discussion about removing all examples from the deprecated components after #1493 will be merged and before next major version (0.61 docs and below will remain untouched).

@rachelnabors

This comment has been minimized.

Copy link
Contributor

rachelnabors commented Feb 7, 2020

Also after thinking about this a bit more I would like to start discussion about removing all examples from the deprecated components after #1493 will be merged and before next major version (0.61 docs and below will remain untouched).

Actually we want to remove all the deprecated components from the sidebar for 0.62. Want to do it for me?

@rachelnabors rachelnabors merged commit b8916d5 into facebook:master Feb 7, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Feb 7, 2020

Keep in mind #1045 while removing pages - if people have bookmarks or page ranked search results we should guide them to the new location for awhile.

@Simek

This comment has been minimized.

Copy link
Contributor

Simek commented Feb 7, 2020

@rickhanlonii I think that @rachelnabors want only to remove entries for the deprecated components from the Sidebar and leave pages intact under versioned 0.62 urls.

@rachelnabors I can help with that, no problem. It should help if you describe exactly what is desirable effect of that change. Currently I'm assuming that you want me to generate versioned docs for 0.62 (they do not exist right now) from the current master and remove deprecated components pages ONLY form the Sidebar in this version. Is that right? I'm not so sure.

espipj added a commit to espipj/react-native-website that referenced this pull request Feb 8, 2020
* DatePickerIOS - Added Snack Examples

* Update datepickerios.md

Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code

* removed unused import statements

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
@rachelnabors

This comment has been minimized.

Copy link
Contributor

rachelnabors commented Feb 15, 2020

@rickhanlonii So @Simek has me right here鈥攚ould be great to just remove the links from the sidebar from 62 onward. Editing only sidebars.json should change this in /docs/next/ and all versions going forward鈥攚hich is what we want! I'd submit a PR for that very thing, @Simek :)

@rickhanlonii

This comment has been minimized.

Copy link
Member

rickhanlonii commented Feb 15, 2020

Yup that works.

kaioduarte added a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
* DatePickerIOS - Added Snack Examples

* Update datepickerios.md

Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code

* removed unused import statements

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can鈥檛 perform that action at this time.