Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityIndicator: add snackplayer/functional component with hooks #1590

Merged
merged 5 commits into from Feb 15, 2020

Conversation

@ronnyiscoding
Copy link
Contributor

ronnyiscoding commented Feb 5, 2020

Open Issue: #1579

  • Added snackplayer functional example for ActivityIndicator component
@ronnyiscoding ronnyiscoding changed the title added snackplayer/functional component with hooks added snackplayer/functional component with hooks (ActivityIndicator) Feb 5, 2020
@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 5, 2020

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

@ronnyiscoding ronnyiscoding requested a review from rachelnabors Feb 5, 2020
@ronnyiscoding ronnyiscoding changed the title added snackplayer/functional component with hooks (ActivityIndicator) ActivityIndicator: added snackplayer/functional component with hooks Feb 5, 2020
@ronnyiscoding ronnyiscoding requested review from kelset and hramos Feb 6, 2020
Copy link
Contributor

rachelnabors left a comment

Ach, you've don't this in the versioned docs! We need the file to be edited here:
https://github.com/facebook/react-native-website/blob/master/docs/activityindicator.md

@@ -341,9 +341,6 @@
"toastandroid": {
"title": "ToastAndroid"
},
"toolbarandroid": {

This comment has been minimized.

Copy link
@Simek

Simek Feb 7, 2020

Contributor

@ronnyiscoding Same problem here.

This comment has been minimized.

Copy link
@ronnyiscoding

ronnyiscoding Feb 7, 2020

Author Contributor

PR updated here 12166a4 thanks!

This comment has been minimized.

Copy link
@Simek

Simek Feb 7, 2020

Contributor

Thank you for the changes.

As @rachelnabors said (which apply for the both PRs) you should update:

  • master docs (docs/activityindicator.md)

not:

  • versioned docs (website/versioned_docs/version-0.61/activityindicator.md)

This comment has been minimized.

Copy link
@ronnyiscoding

ronnyiscoding Feb 7, 2020

Author Contributor

Ok, Thank you, PR updated at 51913e4

@ronnyiscoding ronnyiscoding changed the title ActivityIndicator: added snackplayer/functional component with hooks ActivityIndicator: add snackplayer/functional component with hooks Feb 7, 2020
@ronnyiscoding

This comment has been minimized.

Copy link
Contributor Author

ronnyiscoding commented Feb 7, 2020

Ach, you've don't this in the versioned docs! We need the file to be edited here:
https://github.com/facebook/react-native-website/blob/master/docs/activityindicator.md

Thanks for the review, PR is updated please let me know if this is the right way to contribute 👍

Copy link
Contributor

rachelnabors left a comment

Nicely done! Thanks for adding these examples!

Prettifying the code
@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 15, 2020

Deploy preview for react-native ready!

Built with commit caedf1b

https://deploy-preview-1590--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@rachelnabors rachelnabors merged commit 9fc1183 into facebook:master Feb 15, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
kaioduarte added a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
…ebook#1590)

* added snackplayer/functional component with hooks

* update docs

* restore changes

* PR updates

* Update activityindicator.md

Prettifying the code

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.