Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Image Style Props examples #1602

Open
wants to merge 7 commits into
base: master
from

Conversation

@ronnyiscoding
Copy link
Contributor

ronnyiscoding commented Feb 6, 2020

Issue #1579 Add Image Style Props examples.

@ronnyiscoding ronnyiscoding requested a review from rachelnabors Feb 6, 2020
@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 6, 2020

Oops, something went wrong with this deploy preview.

@charpeni can you look at this?

@ronnyiscoding ronnyiscoding requested review from kelset and hramos Feb 6, 2020
@@ -341,9 +341,6 @@
"toastandroid": {
"title": "ToastAndroid"
},
"toolbarandroid": {

This comment has been minimized.

Copy link
@Simek

Simek Feb 7, 2020

Contributor

Am I assuming correctly that this change was added to the commit by mistake?

This comment has been minimized.

Copy link
@ronnyiscoding

ronnyiscoding Feb 7, 2020

Author Contributor

It is removed by yarn starn command @Simek

This comment has been minimized.

Copy link
@Simek

Simek Feb 7, 2020

Contributor

So it seems that someone forget to add a change generated after building app to their PR which landed on master. Regardless that this change should not be a part of this PR in my opinion.

This comment has been minimized.

Copy link
@ronnyiscoding

ronnyiscoding Feb 7, 2020

Author Contributor

PR update 8d87b86 changes restored

@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 7, 2020

Deploy preview for react-native ready!

Built with commit bda646f

https://deploy-preview-1602--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

rachelnabors left a comment

Wow, such a lot of work you put into making all these examples! You're almost there! But before I can merge your PR, a few requests:

  1. Shorten the titles of the examples. They overflow the Expo title bar!
  2. The third example's class version has an error. Please fix!
  3. Be sure to run your code through Prettier.io
  4. Please remove the Props list you added—the right hand sidebar will suffice!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.