Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Image Style Props examples #1602

Merged
merged 9 commits into from Feb 28, 2020
Merged

docs: add Image Style Props examples #1602

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9d19ec
docs: add Image Style Props examples
ronnycoding Feb 6, 2020
4622438
remove backgroundColor
ronnycoding Feb 6, 2020
0cad766
fix typo
ronnycoding Feb 7, 2020
52d35f8
yarn is removing toolbarandroid
ronnycoding Feb 7, 2020
8d87b86
update PR restoring changes
ronnycoding Feb 7, 2020
0958d2f
PR updates
ronnycoding Feb 7, 2020
bda646f
update en.json
ronnycoding Feb 7, 2020
05c6794
Update image-style-props.md
rachelnabors Feb 27, 2020
94d7eb8
Fixing borked code
rachelnabors Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions website/i18n/en.json
View file
Open in desktop
Expand Up @@ -341,9 +341,6 @@
"toastandroid": {
"title": "ToastAndroid"
},
"toolbarandroid": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I assuming correctly that this change was added to the commit by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is removed by yarn starn command @Simek

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems that someone forget to add a change generated after building app to their PR which landed on master. Regardless that this change should not be a part of this PR in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR update 8d87b86 changes restored

"title": "ToolbarAndroid"
},
"touchablehighlight": {
"title": "TouchableHighlight"
},
Expand Down Expand Up @@ -3410,6 +3407,9 @@
"version-0.61/version-0.61-getting-started": {
"title": "Getting Started"
},
"version-0.61/version-0.61-image-style-props": {
"title": "Image Style Props"
},
"version-0.7/version-0.7-pushnotificationios": {
"title": "PushNotificationIOS"
},
Expand Down