Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clipboard example #1604

Merged
merged 5 commits into from Feb 18, 2020
Merged

added clipboard example #1604

merged 5 commits into from Feb 18, 2020

Conversation

@brunokiafuka
Copy link
Contributor

brunokiafuka commented Feb 6, 2020

#1579,

Added example using hooks to clipboard API.

@brunokiafuka brunokiafuka requested review from hramos and rachelnabors Feb 6, 2020
@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Feb 6, 2020

Deploy preview for react-native ready!

Built with commit d34032f

https://deploy-preview-1604--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Tidying up example a bit
Copy link
Contributor

rachelnabors left a comment

Thanks so much for tackling this!

docs/clipboard.md Outdated Show resolved Hide resolved
@Simek Simek mentioned this pull request Feb 8, 2020
@brunokiafuka

This comment has been minimized.

Copy link
Contributor Author

brunokiafuka commented Feb 10, 2020

Hi @rachelnabors and @Simek, I hope you are all doing well.
what would be the next steps based on #1608.

@Simek

This comment has been minimized.

Copy link
Contributor

Simek commented Feb 10, 2020

@brunokiafuka Hi and thank you for your contribution. Currently we need to wait for maintainers decision, please check out my comment for the more details: #1579 (comment)

Copy link
Contributor

rachelnabors left a comment

Looking good!

Copy link
Contributor

rachelnabors left a comment

Two things:

  1. Why doesn't this example work on Web?
  2. Can you add some padding so the touchable Portion is interactable on Android? Currently it's so high up on the screen that it's under the top OS
    Screenshot 2020-02-10 at 15 23 10
    toolbar!
added style to example
@brunokiafuka brunokiafuka requested a review from rachelnabors Feb 11, 2020
@brunokiafuka

This comment has been minimized.

Copy link
Contributor Author

brunokiafuka commented Feb 11, 2020

@rachelnabors the clipboard API get method only works on android and ios, on web, it can set the item to the clipboard but returns an empty string yet if you try to paste the copied content elsewhere it will work.

Clipboard gives you an interface for setting and getting content from Clipboard on both Android and iOS.
👆🏾 API intro line.

Copy link
Contributor

rachelnabors left a comment

Ok, last round of feedback! Thanks for hanging on!

  1. Can you move the styles to a separate style sheet at the bottom of the page?
  2. Remove the Web from the example via ```SnackPlayer name=Title&supportedPlatforms=ios,android
@brunokiafuka brunokiafuka requested a review from rachelnabors Feb 17, 2020
Copy link
Contributor

rachelnabors left a comment

Awesome work! Thanks so much!

@rachelnabors rachelnabors merged commit 162a7e2 into facebook:master Feb 18, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
kaioduarte added a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
* added clipboard example

* Update clipboard.md

Tidying up example a bit

* Update clipboard.md

added style to example

* fix: set supported platform to mobile added style to object.

* fix: set supported platform to mobile added style to object.

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.