Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Snack example to PixelRatio page #1687

Merged
merged 4 commits into from Mar 3, 2020

Conversation

@Simek
Copy link
Contributor

Simek commented Mar 1, 2020

Refs #1579.

This PR adds Snack example to the Pixel Ratio page. This example is very simple and I have deliberate chosen text representation for the image/resource size calculation, mainly for the clarity what this API can do and which information it provides. But the phrasing might be the first thing to tweak here ; )

Preview:
Screenshot 2020-03-01 at 20 50 10

@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Mar 1, 2020

Deploy preview for react-native ready!

Built with commit ae2f3a0

https://deploy-preview-1687--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

rachelnabors left a comment

Thanks for updating this page! You rock!
sailor-moon_well-done

@Simek

This comment has been minimized.

Copy link
Contributor Author

Simek commented Mar 2, 2020

Example devices list has been updated to contain only currently supported Apple devices.

@rachelnabors rachelnabors merged commit ea9c3ba into facebook:master Mar 3, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.