Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Snack example to the Settings page #1700

Merged
merged 2 commits into from Mar 10, 2020

Conversation

@Simek
Copy link
Contributor

Simek commented Mar 5, 2020

Refs #1579. This PR adds basic Snack example to the Settings API page.

Unfortunately Settings.watchKeys in the current version of React Native do not register and fire callback after Settings.set calls (but callback is called on "outside" changes). This is the reason why example is not working as expected. More information here: facebook/react-native#28213

@rachelnabors guided me thought this process and asked to push the code from the stash in current state. It means that this PR is technically WIP and at least one more commit is expected here.

@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Mar 5, 2020

Deploy preview for react-native ready!

Built with commit 3ba2046

https://deploy-preview-1700--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

rachelnabors left a comment

Thanks for putting so much time and effort into this one!
mlp_fistbump

@rachelnabors rachelnabors merged commit 63e5f28 into facebook:master Mar 10, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.