Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic types to the StyleSheet methods #1723

Merged
merged 5 commits into from Mar 13, 2020

Conversation

@Simek
Copy link
Contributor

Simek commented Mar 10, 2020

Refs #1331

This PR adds basic, missing types to the SteelSheet.compose() and SteelSheet.flatten() methods.

I have also put information about experimental nature of setStyleAttributePreprocessor() in a note box.

Source: facebook/react-native/Libraries/StyleSheet/StyleSheet.js

@react-native-bot

This comment has been minimized.

Copy link

react-native-bot commented Mar 10, 2020

Deploy preview for react-native ready!

Built with commit c17d2c7

https://deploy-preview-1723--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@Simek

This comment has been minimized.

Copy link
Contributor Author

Simek commented Mar 11, 2020

This PR received another update with following changes:

  • restore create() method reference deleted during Component Docs Drive refactor
  • sort method and properties alphabetically
  • remove unused code, improve readability, simplify examples and run them through Prettier
  • update examples and UI to be more coherent with the website

@rachelnabors I also think that StylesSheet page should be moved from the Core Components to the APIs section of the sidebar. It is in suggested position in 0.61 versioned docs. What do you think about that change?

Copy link
Contributor

rachelnabors left a comment

mlp_party
Thanks for all this!

@Simek

This comment has been minimized.

Copy link
Contributor Author

Simek commented Mar 11, 2020

@rachelnabors What about sidebar (last paragraph from my last comment), should we change the position?

@rachelnabors

This comment has been minimized.

Copy link
Contributor

rachelnabors commented Mar 11, 2020

That makes sense to me

@Simek

This comment has been minimized.

Copy link
Contributor Author

Simek commented Mar 13, 2020

@rachelnabors StyleSheet moved : )

@rachelnabors rachelnabors merged commit ea9cd59 into facebook:master Mar 13, 2020
3 checks passed
3 checks passed
ci/circleci: language_lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.