Update instructions on integrating with native apps #3383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cortinico
requested changes
Oct 28, 2022
| Add the React Native and JSC dependency to your app's `build.gradle` file: | ||
| Add the React Native and JavaScript engine dependencies to your `app/build.gradle` file: | ||
|
|
||
| ```gradle |
Contributor
There was a problem hiding this comment.
This script is not correct, given the newest version of React Native 0.71.0.
I'd rather document the new template
Collaborator
|
Hey @michalchudziak, thanks for the contribution! 👍 Since the integration docs has been changed a lot since this PR has been posted, and some of the pages no longer exists I'm going to close this PR. Feel free to create a new one, if there is something incorrect in the latest revision of those guides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the docs on integration with native apps:
I think it'll be great to include Fabric instructions in the near future as well :)