Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Getting Started in Linux to reflect ANDROID_SDK bump #3612

Merged
merged 1 commit into from Mar 7, 2023

Conversation

arushikesarwani94
Copy link
Contributor

Updating Setting up the development environment in Linux documentation to reflect ANDROID_SDK version bump.

React Native is increasing the minimum ANDROID_SDK requirement from Android SDK Platform 31 to Android SDK Platform 33 for 0.72 onwards. Correspondingly changing the Android version. Updating our documentation to reflect the same as macOS & Windows

Found in #3605

Updating Setting up the development environment in Linux documentation to reflect ANDROID_SDK version bump.

React Native is increasing the minimum ANDROID_SDK requirement from Android SDK Platform 31 to Android SDK Platform 33 for 0.72 onwards. Correspondingly changing the Android version. Updating our documentation to reflect the same as macOS & Windows
@netlify
Copy link

netlify bot commented Mar 6, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 269fd10
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/64063c0fff64de000882186e
😎 Deploy Preview https://deploy-preview-3612--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍 Can we backport it also in the docs for 0.71?

@arushikesarwani94 arushikesarwani94 merged commit 86e2d06 into main Mar 7, 2023
1 check passed
@Simek Simek deleted the arushikesarwani94-patch-3 branch March 7, 2023 18:41
@arushikesarwani94
Copy link
Contributor Author

Can we backport it also in the docs for 0.71?

Wasn't the whole point of this change that it's only needed 0.72 onwards ?

@cortinico
Copy link
Contributor

Can we backport it also in the docs for 0.71?

Wasn't the whole point of this change that it's only needed 0.72 onwards ?

We bumped to SDK 33 inside 0.71, so all the references has to be updated in .71 and on main (.72)

@arushikesarwani94
Copy link
Contributor Author

#3615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants