From 065db683a20b273ea3656dead29845327637669a Mon Sep 17 00:00:00 2001 From: Chenglin Liu Date: Thu, 22 Sep 2022 22:52:22 -0700 Subject: [PATCH] add link group label to fbios deps Summary: Currently, fbios link groups depend on supermodules to generate. To continue supporting link groups while allowing us to migrate off supermodules, we'll add a `fbios_link_group` label on all fbios targets to persist the current hierarchical information. Reviewed By: jkeljo Differential Revision: D39543862 fbshipit-source-id: 2abe5b3ee883e77336076d88436a1c84139b5a97 --- BUCK | 8 ++++++++ Libraries/FBLazyVector/BUCK | 1 + Libraries/RCTRequired/BUCK | 1 + React/CoreModules/BUCK | 1 + 4 files changed, 11 insertions(+) diff --git a/BUCK b/BUCK index 55daac353da0bf..f983e33303ef3e 100644 --- a/BUCK +++ b/BUCK @@ -605,6 +605,7 @@ rn_apple_library( ], inherited_buck_flags = get_static_library_ios_flags(), labels = [ + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -830,6 +831,7 @@ rn_apple_library( "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", "extension_api_allow_unsafe_unavailable_usages", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -880,6 +882,7 @@ rn_apple_library( labels = [ "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -939,6 +942,7 @@ rn_apple_library( "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", "extension_api_allow_unsafe_unavailable_usages", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -987,6 +991,7 @@ rn_apple_library( "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", "extension_api_allow_unsafe_unavailable_usages", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -1039,6 +1044,7 @@ rn_apple_library( "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", "extension_api_allow_unsafe_unavailable_usages", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -1120,6 +1126,7 @@ rn_apple_library( "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", "extension_api_allow_unsafe_unavailable_usages", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], @@ -1287,6 +1294,7 @@ rn_apple_library( labels = [ "depslint_never_remove", "disable_plugins_only_validation", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], diff --git a/Libraries/FBLazyVector/BUCK b/Libraries/FBLazyVector/BUCK index 89ab4c058e5b8c..37c93703b49f38 100644 --- a/Libraries/FBLazyVector/BUCK +++ b/Libraries/FBLazyVector/BUCK @@ -13,6 +13,7 @@ fb_apple_library( extension_api_only = True, frameworks = [], labels = [ + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], diff --git a/Libraries/RCTRequired/BUCK b/Libraries/RCTRequired/BUCK index 34b493a0e37232..a5d9a58eba81a3 100644 --- a/Libraries/RCTRequired/BUCK +++ b/Libraries/RCTRequired/BUCK @@ -11,6 +11,7 @@ fb_apple_library( extension_api_only = True, frameworks = ["Foundation"], labels = [ + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ], diff --git a/React/CoreModules/BUCK b/React/CoreModules/BUCK index 750745304e9090..01bb7fc1aed3ff 100644 --- a/React/CoreModules/BUCK +++ b/React/CoreModules/BUCK @@ -38,6 +38,7 @@ rn_apple_library( labels = [ "depslint_never_remove", # Some old NativeModule still relies on +load unfortunately. "disable_plugins_only_validation", + "fbios_link_group:xplat/default/public.react_native.infra", "pfh:ReactNative_CommonInfrastructurePlaceholder", "supermodule:xplat/default/public.react_native.infra", ],