Permalink
Browse files

fix direction of VerticalSwipeJump gestures

Summary:
When something comes in from the right, we swipe from left to
right to move back. That means, when something comes in from the bottom,
we should swipe from top to bottom to get rid of it. This diff makes that
behavior occur - right now it's somewhat nonsensical as both jumpBack
and jumpForward are mapped to the same gesture.

thanks to #11192 for making gestures work on VerticalUpSwipeJumps

Reviewed By: ericvicenti, shergin

Differential Revision: D4412129

fbshipit-source-id: 6a3b202b0a90ca459b4ef106ba5bf48d0b1aec9e
  • Loading branch information...
phorust authored and facebook-github-bot committed Jan 13, 2017
1 parent 154e183 commit 09801aac302c4fa741f92ee2c6ffe906c6118a5b
Showing with 3 additions and 3 deletions.
  1. +3 −3 Libraries/CustomComponents/Navigator/NavigatorSceneConfigs.js
@@ -32,8 +32,8 @@
'use strict';
var Dimensions = require('Dimensions');
var PixelRatio = require('PixelRatio');
var I18nManager = require('I18nManager');
var PixelRatio = require('PixelRatio');
var buildStyleInterpolator = require('buildStyleInterpolator');
@@ -745,7 +745,7 @@ var NavigatorSceneConfigs = {
...BaseConfig,
gestures: {
jumpBack: {
...BaseDownUpGesture,
...BaseUpDownGesture,
overswipe: BaseOverswipeConfig,
edgeHitWidth: null,
isDetachable: true,
@@ -766,7 +766,7 @@ var NavigatorSceneConfigs = {
...BaseConfig,
gestures: {
jumpBack: {
...BaseUpDownGesture,
...BaseDownUpGesture,
overswipe: BaseOverswipeConfig,
edgeHitWidth: null,
isDetachable: true,

0 comments on commit 09801aa

Please sign in to comment.