Please sign in to comment.
fix error caused by first argument short when calling warning function
Summary: <details> Thanks for submitting a PR! Please read these instructions carefully: - [X] Explain the **motivation** for making this change. -  Provide a **test plan** demonstrating that the code is solid. - [X] Match the **code formatting** of the rest of the codebase. - [X] Target the `master` branch, NOT a "stable" branch. Please read the [Contribution Guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md) to learn more about contributing to React Native. </details> My app crashed when I call navigator.geolocation.stopObserving(). I found it is caused by the reason that one argument short. So I added false to the first argument. Then bug is fixed. 1. call both navigator.geolocation.watchPosition and navigator.geolocation.getCurrentPosition 2. then call navigator.geolocation.stopObserving() 3. error happened before I fixed, and correct Warning "Called stopObserving with existing subscriptions." shown after I fixed. Closes #14673 Differential Revision: D5301503 Pulled By: javache fbshipit-source-id: 9e85064beb1052bb89bf42355ffd308fe9eaec53
- Loading branch information...